[GitHub] [rocketmq] zhouxinyu removed a comment on pull request #3847: [ISSUE #3831] Swapping mapped-byte-buffer to save memory on a system with extra-large disks.

[GitBox <gi...@apache.org>]

zhouxinyu removed a comment on pull request #3847:
URL: https://github.com/apache/rocketmq/pull/3847#issuecomment-1039797956


   More suggested comments:
   1. Add some comments for interface Swappable, it's difficult to understand the specific meaning of `swapMap` and `cleanSwappedMap` directly. 
   2. Add unit tests for this PR, and the implementations of `Swappable`. 
   3. Maybe only MappedFile and MappedFileQueue implement `Swappable` is enough, it's a little strange that CommitLog and ConsumeQueueStore also is a subclass of this interface.
   
   And a technical question: 
   1. We mapped twice for writing when the old buffer hasn't been cleaned, is there a write conflict problem in this situation? Although the cleaner won't clean the last writing file, the file doesn't know it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org