You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "mapleFU (via GitHub)" <gi...@apache.org> on 2025/03/04 13:21:59 UTC

Re: [PR] GH-43573: [C++] Copy bitmap when casting from string-view to offset string and binary types [arrow]

mapleFU commented on code in PR #44822:
URL: https://github.com/apache/arrow/pull/44822#discussion_r1979424623


##########
cpp/src/arrow/compute/kernels/scalar_cast_string.cc:
##########
@@ -46,6 +46,25 @@ namespace internal {
 
 namespace {
 
+Result<std::shared_ptr<Buffer>> GetOrCopyNullBitmapBuffer(const ArraySpan& in_array,

Review Comment:
   It's ok to me but how could we naming and putting this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org