[GitHub] [commons-vfs] garydgregory commented on a change in pull request #151: Refactor getOutputStream

[GitBox <gi...@apache.org>]

garydgregory commented on a change in pull request #151:
URL: https://github.com/apache/commons-vfs/pull/151#discussion_r545127889



##########
File path: commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java
##########
@@ -1232,6 +1233,7 @@ public FileName getName() {
         return fileName;
     }
 
+    // TODO: remove this method for the next major version as it is unused

Review comment:
       It's a public method, you do not know who uses it, so you can't say it's "unused". I think this comment can be dropped.
   

##########
File path: commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileOutputStream.java
##########
@@ -92,13 +90,7 @@ public void close() throws IOException {
         if (exception != null) {
             throw exception;
         }
-        try {
-            this.closed = true;
-            // Close the
-            this.file.endOutput();
-        } catch (final Exception e) {
-            throw new FileSystemException(e);
-        }
+        this.closed = true;

Review comment:
       This is a change in behavior that is likely to break some apps since `endOutput()` is no longer called. Needs more study...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org