[GitHub] [incubator-pinot] mcvsubbu commented on issue #4695: [Resource Assignment] Plug in resource assignment to LLC REALTIME table

[GitBox <gi...@apache.org>]

mcvsubbu commented on issue #4695: [Resource Assignment] Plug in resource assignment to LLC REALTIME table
URL: https://github.com/apache/incubator-pinot/pull/4695#issuecomment-542818850
 
 
   I have asked @npawar  to look at the class from the standpoint of:
   - What if an exception is raised where we would have returned a boolean 'false' before. It seemed like we would continue to do what we can, but now we abort.
   - Log messages: Used to be that every step is logged, so that we can reconstruct what happened during a repair or segment assignment. It will help in reasoning about  problems like : "this segment was not repaired", "this partition stopped consuming". With the removal of logs, we need to be careful that we clearly log an exception that may have happened while we try to do an operation, or otherwise log the branches that we may take that may lead us to NOT completing an operation. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org