You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "tim-goto (via GitHub)" <gi...@apache.org> on 2024/06/18 13:07:33 UTC
[PR] fix: correct path for grafana dockerfile [incubator-devlake]
tim-goto opened a new pull request, #7628:
URL: https://github.com/apache/incubator-devlake/pull/7628
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
### ⚠️ Pre Checklist
> Please complete _ALL_ items in this checklist, and remove before submitting
- [x] I have read through the [Contributing Documentation](https://devlake.apache.org/community/).
- [ ] I have added relevant tests.
- [ ] I have added relevant documentation.
- [x] I will add labels to the PR, such as `pr-type/bug-fix`, `pr-type/feature-development`, etc.
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes.
Please fill out as many sections below as possible.
-->
### Summary
fix the grafana dockerfile path
### Does this close any open issues?
### Screenshots
### Other Information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: correct path for grafana dockerfile [incubator-devlake]
Posted by "tim-goto (via GitHub)" <gi...@apache.org>.
tim-goto commented on code in PR #7628:
URL: https://github.com/apache/incubator-devlake/pull/7628#discussion_r1644600510
##########
Makefile:
##########
@@ -40,7 +40,7 @@ push-config-ui-image: build-config-ui-image
docker push $(IMAGE_REPO)/devlake-config-ui:$(TAG)
push-grafana-image: build-grafana-image
- docker push $(IMAGE_REPO)/devlake-dashboard:$(TAG)
Review Comment:
there was an invalid character here, unfortunately the github webui doesn't show it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: correct path for grafana dockerfile [incubator-devlake]
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on code in PR #7628:
URL: https://github.com/apache/incubator-devlake/pull/7628#discussion_r1645286453
##########
Makefile:
##########
@@ -40,7 +40,7 @@ push-config-ui-image: build-config-ui-image
docker push $(IMAGE_REPO)/devlake-config-ui:$(TAG)
push-grafana-image: build-grafana-image
- docker push $(IMAGE_REPO)/devlake-dashboard:$(TAG)
Review Comment:
Yup, spaces vs tab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: correct path for grafana dockerfile [incubator-devlake]
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh merged PR #7628:
URL: https://github.com/apache/incubator-devlake/pull/7628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org