[GitHub] [airflow] dstandish commented on a diff in pull request #34392: Mark tasks with `all_skipped` trigger rule as `skipped` if any task is in `upstream_failed` state

["dstandish (via GitHub)" <gi...@apache.org>]

dstandish commented on code in PR #34392:
URL: https://github.com/apache/airflow/pull/34392#discussion_r1340545517


##########
airflow/ti_deps/deps/trigger_rule_dep.py:
##########
@@ -381,6 +381,8 @@ def _evaluate_direct_relatives() -> Iterator[TIDepStatus]:
                 elif trigger_rule == TR.ALL_SKIPPED:
                     if success or failed:
                         new_state = TaskInstanceState.SKIPPED
+                    elif upstream_done and upstream_failed:
+                        new_state = TaskInstanceState.UPSTREAM_FAILED

Review Comment:
   So....
   
   Why should upstream failed not be treated the exact same as failed?  
   
   I agree that it's weird that this rule results in "skip" when upstream is "fail".  But, that's how it is.  It seems that upstream_failed should treated no different from failed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org