[jira] Commented: (RIVER-325) LookupLocator is missing ways to specify SocketFactory

["Peter Firmstone (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RIVER-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796903#action_12796903 ] 

Peter Firmstone commented on RIVER-325:
---------------------------------------

>From river dev mail list:

Peter Firmstone wrote:
> Lets add the constructor, it won't break anything and commit the patch, I've read the patch its straight forward, then we'll run the tests again.
> This is only a trivial change.

I guess you're refering to the patch for RIVER-71. I agree that the patch is a trivial change.

For the constructor issue i've opened another, RIVER-325. I will try to make the impact of the patch as low as possible. The only concern i have with it, is if we expect the locator to be marshalled from one participant to another, and when versions differ. The class resides in jini-core, so will never be loaded over the network. In this case, we should change the serialVersionUID and provide compatibility serialization support, and i'm not sure if this will work out ok.

> I'd also like to say thanks for the patch Sim and welcome to Apache River. 

> LookupLocator is missing ways to specify SocketFactory
> ------------------------------------------------------
>
>                 Key: RIVER-325
>                 URL: https://issues.apache.org/jira/browse/RIVER-325
>             Project: River
>          Issue Type: Improvement
>          Components: net_jini_discovery
>            Reporter: Sim IJskes
>            Priority: Minor
>         Attachments: LookupLocator.java.patch
>
>
> LookupLocator has no way to specify a SocketFactory. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.