You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "felixwluo (via GitHub)" <gi...@apache.org> on 2024/01/30 09:26:29 UTC
[PR] [Fix](compile) fix compile failure on be [doris]
felixwluo opened a new pull request, #30579:
URL: https://github.com/apache/doris/pull/30579
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
/data/home/felixwluo/dev/doris-master/doris/be/src/vec/exec/data_gen_functions/vnumbers_tvf.cpp:40:26: error: unused variable 'NUMBER' [-Werror,-Wunused-const-variable]
40 | const static std::string NUMBER = std::string {"number"};
| ^~~~~~
/data/home/felixwluo/dev/doris-master/doris/be/src/vec/exec/data_gen_functions/vnumbers_tvf.cpp:41:26: error: unused variable 'ZERO' [-Werror,-Wunused-const-variable]
41 | const static std::string ZERO = std::string {"zero"};
| ^~~~
2 errors generated.
fix:Delete unused variables
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](compile) fix compile failure on be [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30579:
URL: https://github.com/apache/doris/pull/30579#issuecomment-1916467823
<details>
<summary>TPC-H: <b>Total hot run time: 50201 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a77e48d8f886fd67e7fd9f4f4f867ba0231805d1, data reload: false
------ Round 1 ----------------------------------
q1 17669 4347 4381 4347
q2 2022 150 138 138
q3 10325 1921 1900 1900
q4 10146 1245 1333 1245
q5 8387 3990 4019 3990
q6 230 125 125 125
q7 2026 1606 1658 1606
q8 9304 2732 2714 2714
q9 10810 10556 10502 10502
q10 8644 3564 3496 3496
q11 416 249 245 245
q12 461 301 299 299
q13 18365 4016 4015 4015
q14 348 329 329 329
q15 503 456 451 451
q16 722 601 591 591
q17 1153 976 996 976
q18 7264 6931 7168 6931
q19 1705 1580 1536 1536
q20 539 307 305 305
q21 4470 4095 4059 4059
q22 493 401 402 401
Total cold run time: 116002 ms
Total hot run time: 50201 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4364 4315 4292 4292
q2 320 224 234 224
q3 4205 4167 4140 4140
q4 2745 2721 2734 2721
q5 7316 7179 7188 7179
q6 236 117 115 115
q7 3239 2890 2796 2796
q8 4368 4591 4509 4509
q9 17174 17075 16949 16949
q10 4222 4230 4262 4230
q11 788 714 686 686
q12 1010 851 857 851
q13 7227 3751 3710 3710
q14 461 421 432 421
q15 493 467 452 452
q16 753 733 721 721
q17 3785 3894 3852 3852
q18 8773 8837 8653 8653
q19 1722 1705 1663 1663
q20 2393 2185 2096 2096
q21 8604 8554 8511 8511
q22 1076 958 904 904
Total cold run time: 85274 ms
Total hot run time: 79675 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](compile) fix compile failure on be [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30579:
URL: https://github.com/apache/doris/pull/30579#issuecomment-1916425320
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](compile) fix compile failure on be [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30579:
URL: https://github.com/apache/doris/pull/30579#issuecomment-1916486101
TeamCity be ut coverage result:
Function Coverage: 37.84% (8034/21232)
Line Coverage: 29.54% (65463/221590)
Region Coverage: 28.96% (33621/116075)
Branch Coverage: 24.83% (17251/69488)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a77e48d8f886fd67e7fd9f4f4f867ba0231805d1_a77e48d8f886fd67e7fd9f4f4f867ba0231805d1/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](compile) fix compile failure on be [doris]
Posted by "felixwluo (via GitHub)" <gi...@apache.org>.
felixwluo commented on PR #30579:
URL: https://github.com/apache/doris/pull/30579#issuecomment-1916418211
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](compile) fix compile failure on be [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30579:
URL: https://github.com/apache/doris/pull/30579#issuecomment-1916518381
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit a77e48d8f886fd67e7fd9f4f4f867ba0231805d1 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 21.8 seconds inserted 10000000 Rows, about 458K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](compile) fix compile failure on be [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30579:
URL: https://github.com/apache/doris/pull/30579#issuecomment-1916429424
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](compile) fix compile failure on be [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30579:
URL: https://github.com/apache/doris/pull/30579#issuecomment-1916527967
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](compile) fix compile failure on be [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30579:
URL: https://github.com/apache/doris/pull/30579#issuecomment-1916499298
<details>
<summary>TPC-DS: <b>Total hot run time: 237419 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a77e48d8f886fd67e7fd9f4f4f867ba0231805d1, data reload: false
query1 912 393 384 384
query2 6536 2240 2043 2043
query3 6919 200 204 200
query4 20157 17923 18049 17923
query5 19726 6269 6257 6257
query6 278 215 218 215
query7 4140 308 303 303
query8 257 246 219 219
query9 3132 2688 2630 2630
query10 417 301 306 301
query11 11375 10667 10736 10667
query12 117 76 78 76
query13 5662 660 627 627
query14 17498 13851 13324 13324
query15 395 229 241 229
query16 6454 263 278 263
query17 3183 889 872 872
query18 2261 399 403 399
query19 195 145 145 145
query20 80 80 76 76
query21 179 98 94 94
query22 5370 5057 5211 5057
query23 32634 32034 31833 31833
query24 6918 6556 6592 6556
query25 522 425 423 423
query26 531 165 161 161
query27 1854 291 287 287
query28 6073 2219 2184 2184
query29 2933 2627 2637 2627
query30 242 158 161 158
query31 898 726 748 726
query32 66 56 57 56
query33 387 255 247 247
query34 842 466 468 466
query35 1088 946 907 907
query36 1510 1513 1595 1513
query37 89 62 60 60
query38 3083 2931 2920 2920
query39 1370 1334 1334 1334
query40 195 92 101 92
query41 37 33 32 32
query42 93 88 83 83
query43 758 565 614 565
query44 1110 713 711 711
query45 241 231 229 229
query46 1221 963 973 963
query47 1776 1864 1598 1598
query48 975 676 665 665
query49 616 359 368 359
query50 858 588 605 588
query51 5683 5537 5444 5444
query52 86 84 82 82
query53 444 327 318 318
query54 2412 2209 2214 2209
query55 82 77 76 76
query56 224 201 192 192
query57 1356 1067 1024 1024
query58 233 196 204 196
query59 3393 3417 3247 3247
query60 207 189 193 189
query61 86 87 84 84
query62 829 524 454 454
query63 469 342 329 329
query64 2015 1300 1286 1286
query65 3712 3647 3665 3647
query66 795 364 362 362
query67 15547 17210 15589 15589
query68 8166 653 667 653
query69 553 364 332 332
query70 2013 1699 1714 1699
query71 371 312 312 312
query72 4500 3323 3357 3323
query73 735 308 318 308
query74 6324 6011 5877 5877
query75 4327 3547 3541 3541
query76 4621 1185 1222 1185
query77 555 251 240 240
query78 32739 50300 46944 46944
query79 15530 642 641 641
query80 4637 381 373 373
query81 565 231 226 226
query82 1064 99 96 96
query83 416 132 127 127
query84 259 69 67 67
query85 2364 296 282 282
query86 462 372 381 372
query87 3246 3066 2985 2985
query88 6968 2318 2306 2306
query89 448 333 297 297
query90 2521 211 204 204
query91 166 123 115 115
query92 67 47 53 47
query93 6150 571 547 547
query94 1668 202 206 202
query95 1118 1062 1079 1062
query96 649 325 320 320
query97 6407 6314 6313 6313
query98 192 176 174 174
query99 3804 874 987 874
Total cold run time: 345341 ms
Total hot run time: 237419 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](compile) fix compile failure on be [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30579:
URL: https://github.com/apache/doris/pull/30579#issuecomment-1916511557
<details>
<summary>ClickBench: <b>Total hot run time: 30.23 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a77e48d8f886fd67e7fd9f4f4f867ba0231805d1, data reload: false
query1 0.03 0.02 0.02
query2 0.06 0.02 0.02
query3 0.25 0.05 0.04
query4 1.85 0.06 0.06
query5 0.53 0.53 0.52
query6 1.25 0.61 0.62
query7 0.02 0.01 0.01
query8 0.04 0.02 0.02
query9 0.52 0.49 0.47
query10 0.54 0.53 0.55
query11 0.11 0.09 0.08
query12 0.12 0.08 0.09
query13 0.61 0.61 0.60
query14 0.79 0.80 0.78
query15 0.78 0.76 0.78
query16 0.36 0.37 0.36
query17 1.01 1.01 1.00
query18 0.22 0.27 0.24
query19 1.85 1.77 1.85
query20 0.01 0.00 0.01
query21 15.48 0.56 0.55
query22 1.92 1.74 1.26
query23 17.47 0.94 0.98
query24 9.06 1.30 0.68
query25 1.56 0.14 0.11
query26 0.45 0.15 0.14
query27 0.10 0.12 0.11
query28 4.99 0.77 0.77
query29 12.62 2.35 2.36
query30 0.61 0.52 0.50
query31 2.82 0.39 0.38
query32 3.41 0.49 0.50
query33 3.10 3.12 3.09
query34 15.26 4.84 4.80
query35 4.85 4.87 4.83
query36 1.07 1.00 1.01
query37 0.06 0.05 0.04
query38 0.04 0.02 0.02
query39 0.02 0.02 0.02
query40 0.16 0.14 0.14
query41 0.07 0.01 0.02
query42 0.02 0.01 0.01
query43 0.02 0.02 0.02
Total cold run time: 106.11 s
Total hot run time: 30.23 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](compile) fix compile failure on be [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30579:
URL: https://github.com/apache/doris/pull/30579#issuecomment-1916527902
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org