[GitHub] [doris] zxealous commented on a diff in pull request #13487: [Feature](remote)Add schema change for remote storage file

[GitBox <gi...@apache.org>]

zxealous commented on code in PR #13487:
URL: https://github.com/apache/doris/pull/13487#discussion_r999431563


##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -156,7 +167,7 @@ template Status BetaRowsetWriter::_add_row(const ContiguousRow& row);
 
 Status BetaRowsetWriter::add_rowset(RowsetSharedPtr rowset) {
     assert(rowset->rowset_meta()->rowset_type() == BETA_ROWSET);
-    RETURN_NOT_OK(rowset->link_files_to(_context.tablet_path, _context.rowset_id));
+    RETURN_NOT_OK(rowset->link_files_to(_context.rowset_dir, _context.rowset_id));

Review Comment:
   Function link_files_to() will check whether dst_path is exist, but it use function FileUtils::check_exist(dst_path), may be it should change to fs->exists().



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org