You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by diegosalvi <gi...@git.apache.org> on 2017/06/27 08:54:38 UTC

[GitHub] bookkeeper pull request #215: Issue #: Remove useless and misleading '&= tru...

GitHub user diegosalvi opened a pull request:

    https://github.com/apache/bookkeeper/pull/215

    Issue #: Remove useless and misleading '&= true'

    This is just a super minor issue, I stumbled upon it looking into https://github.com/apache/bookkeeper/pull/58...
    
    Assignments like 'shutDownTask =& true' aren't useful at all. I presume that compiler could strip them out but the code is less readable. (Just note that 'x & true == x').
    
    Removed useless assignments.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/diegosalvi/bookkeeper master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bookkeeper/pull/215.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #215
    
----
commit 22a7e87e082c5e22d1df1a55ef4754bb86c13eaf
Author: Diego Salvi <lo...@gmail.com>
Date:   2017-06-27T08:14:08Z

    Remove useless and misleading '&= true'

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bookkeeper pull request #215: Issue 216: Remove useless and misleading '&= t...

Posted by sijie <gi...@git.apache.org>.
Github user sijie closed the pull request at:

    https://github.com/apache/bookkeeper/pull/215


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---