[GitHub] [kafka] ijuma commented on a change in pull request #8585: KAFKA-9938; Debug consumer should be able to fetch from followers

[GitBox <gi...@apache.org>]

ijuma commented on a change in pull request #8585:
URL: https://github.com/apache/kafka/pull/8585#discussion_r419159612



##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -949,8 +949,11 @@ class ReplicaManager(val config: KafkaConfig,
     else
       FetchHighWatermark
 
-    // Restrict fetching to leader if request is from follower or from a client with older version (no ClientMetadata)
-    val fetchOnlyFromLeader = isFromFollower || (isFromConsumer && clientMetadata.isEmpty)
+    // Restrict fetching to leader if request is from follower or from an ordinary consumer
+    // with an older version (which is implied by no ClientMetadata)

Review comment:
       Seems like this comment is a bit redundant. The main useful info is that no ClientMetadata means older version, could we have a method name that made that clear and then the comment would not be needed?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org