[GitHub] [commons-codec] nhojpatrick commented on issue #40: CODEC-286 upgrade to commons-lang v3.9

[GitBox <gi...@apache.org>]

nhojpatrick commented on issue #40: CODEC-286 upgrade to commons-lang v3.9
URL: https://github.com/apache/commons-codec/pull/40#issuecomment-593922927
 
 
   > Having a read of this and you can specify the test source and target separately (see [maven compiler plugin](https://maven.apache.org/plugins/maven-compiler-plugin/testCompile-mojo.html)):
   > 
   > ```
   >     <maven.compiler.source>1.7</maven.compiler.source>
   >     <maven.compiler.target>1.7</maven.compiler.target>
   >     <maven.compiler.testSource>1.8</maven.compiler.testSource>
   >     <maven.compiler.testTarget>1.8</maven.compiler.testTarget>
   > ```
   > 
   > So you can upgrade the build toolchain and tests to JUnit 5 but still support codec at 1.7. When I made the above changes to the pom this worked fine:
   > 
   > ```
   > @Test
   > public void useLambda() {
   >     IntUnaryOperator f = i -> i * i;
   >     Assert.assertEquals(9, f.applyAsInt(3));
   > }
   > ```
   > 
   > The class files extracted from the jar after running `mvn package` are version 7 (major version: 51) when inspected using `javap -v`.
   > 
   > Q. Is this going to work for all the other changes you are doing to support a module-info build?
   
   changed as suggested

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services