[GitHub] [flink] alpreu commented on a diff in pull request #19552: [FLINK-27185][connectors][formats] Convert format modules to assertj

[GitBox <gi...@apache.org>]

alpreu commented on code in PR #19552:
URL: https://github.com/apache/flink/pull/19552#discussion_r866808922


##########
flink-formats/flink-sequence-file/src/test/java/org/apache/flink/formats/sequencefile/SerializableHadoopConfigurationTest.java:
##########
@@ -55,8 +57,8 @@ public void customPropertiesSurviveSerializationDeserialization()
         final SerializableHadoopConfiguration deserializableConfigUnderTest =
                 deserializeAndGetConfiguration(serializedConfigUnderTest);
 
-        Assert.assertThat(
-                deserializableConfigUnderTest.get(), hasTheSamePropertiesAs(configuration));
+        assertThat(deserializableConfigUnderTest.get())
+                .satisfies(matching(hasTheSamePropertiesAs(configuration)));

Review Comment:
   As discussed offline, we decided to keep it as is because converting the Matchers into AssertJ Assertion classes introduces a lot of boilerplate and feels very clunky



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org