You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/04 02:02:48 UTC

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

Yiyiyimu commented on a change in pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#discussion_r483344517



##########
File path: apisix/core/config_etcd.lua
##########
@@ -453,7 +476,7 @@ function _M.new(key, opts)
         values = nil,
         need_reload = true,

Review comment:
       Hi @nic-chen , currently after removing init_etcd, test would fail in etcd_sync.t that it could not auto update prev_index as shown [here](https://github.com/apache/apisix/pull/2036/checks?check_run_id=1066582120#step:6:107). Since removing init_etcd would not set need_reload to false so it could not get to watch anymore.
   
   Do you have any suggestions on how to modify etcd_sync test file




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org