[GitHub] tomcat pull request #103: Use initSQL instead of Validator on connection ini...

[jihor <gi...@git.apache.org>]

GitHub user jihor opened a pull request:

    https://github.com/apache/tomcat/pull/103

    Use initSQL instead of Validator on connection initialization

    As of now, if Validator (not to be confused with validationQuery) is defined for the connection pool, initSQL will not be used on connection initialization, which I think is a bug, not a feature.
    
    This commit changes this behavior so if initSQL is present, it will be used on connection initialization (and only then) instead of Validator.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jihor/tomcat trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomcat/pull/103.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #103
    
----
commit 970b4ce0afb8a90d7dc1c4bbe921dc3e1e4fbb78
Author: jihor <dm...@...>
Date:   2018-03-21T12:51:04Z

    Use initSQL instead of Validator on connection initialization if initSQL is present

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] tomcat issue #103: Use initSQL instead of Validator on connection initializa...

[ChristopherSchultz <gi...@git.apache.org>]

Github user ChristopherSchultz commented on the issue:

    https://github.com/apache/tomcat/pull/103
  
    Honestly, I would expect `initSQL` to be executed regardless of any other configuration (e.g. Validator present or not).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org