You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/08/01 14:42:07 UTC
[GitHub] [fineract] renovate-bot opened a new pull request #1227: Update dependency io.swagger.codegen.v3:swagger-codegen-cli to v3.0.21
renovate-bot opened a new pull request #1227:
URL: https://github.com/apache/fineract/pull/1227
This PR contains the following updates:
| Package | Update | Change |
|---|---|---|
| io.swagger.codegen.v3:swagger-codegen-cli | patch | `3.0.20` -> `3.0.21` |
---
### Renovate configuration
:date: **Schedule**: At any time (no schedule defined).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#apache/fineract).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1227: Update dependency io.swagger.codegen.v3:swagger-codegen-cli to v3.0.21
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1227:
URL: https://github.com/apache/fineract/pull/1227#issuecomment-667692721
Rebasing to retry, but expecting this to fail now after #1228... please wait until we see that this still builds now, after a Renovate rebased it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger closed pull request #1227: Update dependency io.swagger.codegen.v3:swagger-codegen-cli to v3.0.21
Posted by GitBox <gi...@apache.org>.
vorburger closed pull request #1227:
URL: https://github.com/apache/fineract/pull/1227
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on a change in pull request #1227: Update dependency io.swagger.codegen.v3:swagger-codegen-cli to v3.0.21
Posted by GitBox <gi...@apache.org>.
vorburger commented on a change in pull request #1227:
URL: https://github.com/apache/fineract/pull/1227#discussion_r463996445
##########
File path: fineract-provider/build.gradle
##########
@@ -853,7 +853,7 @@ generateGitProperties.outputs.upToDateWhen { false }
//This is for swagger code generation
dependencies {
- swaggerCodegen 'io.swagger.codegen.v3:swagger-codegen-cli:3.0.20'
+ swaggerCodegen 'io.swagger.codegen.v3:swagger-codegen-cli:3.0.21'
Review comment:
> we should set up .travis.yml as soon as possible so that it can catch these problems for us.
Would you like to contribute a PR doing so?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] forking-renovate[bot] commented on pull request #1227: Update dependency io.swagger.codegen.v3:swagger-codegen-cli to v3.0.21
Posted by GitBox <gi...@apache.org>.
forking-renovate[bot] commented on pull request #1227:
URL: https://github.com/apache/fineract/pull/1227#issuecomment-667731412
### Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will now ignore this update (3.0.21). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the `ignoreDeps` array of your renovate config.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] Grandolf49 commented on a change in pull request #1227: Update dependency io.swagger.codegen.v3:swagger-codegen-cli to v3.0.21
Posted by GitBox <gi...@apache.org>.
Grandolf49 commented on a change in pull request #1227:
URL: https://github.com/apache/fineract/pull/1227#discussion_r463980202
##########
File path: fineract-provider/build.gradle
##########
@@ -853,7 +853,7 @@ generateGitProperties.outputs.upToDateWhen { false }
//This is for swagger code generation
dependencies {
- swaggerCodegen 'io.swagger.codegen.v3:swagger-codegen-cli:3.0.20'
+ swaggerCodegen 'io.swagger.codegen.v3:swagger-codegen-cli:3.0.21'
Review comment:
@vorburger
It turns out (for some reason) that `./gradlew generateSwaggerCode` only works for version <= `3.0.18` and not above. This is a bug in swagger codegen https://github.com/swagger-api/swagger-codegen/issues/10157
So for now, we'll have to set it to `3.0.18`. Also, we should set up .travis.yml as soon as possible so that it can catch these problems for us.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] Grandolf49 commented on a change in pull request #1227: Update dependency io.swagger.codegen.v3:swagger-codegen-cli to v3.0.21
Posted by GitBox <gi...@apache.org>.
Grandolf49 commented on a change in pull request #1227:
URL: https://github.com/apache/fineract/pull/1227#discussion_r463997071
##########
File path: fineract-provider/build.gradle
##########
@@ -853,7 +853,7 @@ generateGitProperties.outputs.upToDateWhen { false }
//This is for swagger code generation
dependencies {
- swaggerCodegen 'io.swagger.codegen.v3:swagger-codegen-cli:3.0.20'
+ swaggerCodegen 'io.swagger.codegen.v3:swagger-codegen-cli:3.0.21'
Review comment:
Yes sure, I'll setup the .travis.yml and raise a PR.
Just to clarify, we want add 1. generate and 2. build to the .travis.yml file right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1227: Update dependency io.swagger.codegen.v3:swagger-codegen-cli to v3.0.21
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1227:
URL: https://github.com/apache/fineract/pull/1227#issuecomment-667731325
NOK as per https://github.com/swagger-api/swagger-codegen/issues/10157
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org