[GitHub] kakoni commented on issue #4193: Init docker for local development environment.

[GitBox <gi...@apache.org>]

kakoni commented on issue #4193: Init docker for local development environment.
URL: https://github.com/apache/incubator-superset/pull/4193#issuecomment-418257252
 
 
   Few comments;
   1) Instead of doing this in compose config
   ```
   superset:
       image: apache/incubator-superset
   ```
   why not change this to
   ```
     superset:
       build: .
   ```
   and get rid of docker-build.sh ?
   
   2) entrypoint. Should this have dev option or even run local with something this;
   ```
   elif [ "$SUPERSET_ENV" = "local" ]; then
       superset runserver -d &
       cd /home/work/incubator-superset/superset/assets
       npm run dev
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org