You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/26 19:52:22 UTC
[GitHub] [airflow] potiuk opened a new pull request #14487: Prepare to release the next wave of providers:
potiuk opened a new pull request #14487:
URL: https://github.com/apache/airflow/pull/14487
Regular providers:
* apache.spark - 1.0.2
* cncf.kubernetes - 1.0.2
* google - 2.1.0
* jenkins - 1.1.0
* mysql - 1.0.2
* salesforce - 2.0.0
* slack - 3.0.0
* ssh - 1.2.0
* tableau - 1.0.0
* telegram - 1.0.2
Backport providers (all in version 2021.3.3):
* apache.spark cncf.kubernetes google jenkins mysql salesforce
slack ssh tableau
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14487: Prepare to release the next wave of providers:
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14487:
URL: https://github.com/apache/airflow/pull/14487#issuecomment-786865221
> What about Amazon & Azure?
> looking at the modified files It doesn't appear in the list however it seems it is going to be released but not for backported?
oh yeah
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14487: Prepare to release the next wave of providers:
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14487:
URL: https://github.com/apache/airflow/pull/14487#issuecomment-787043154
[The Workflow run](https://github.com/apache/airflow/actions/runs/605202250) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14487: Prepare to release the next wave of providers:
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14487:
URL: https://github.com/apache/airflow/pull/14487#issuecomment-786867423
> > What about Amazon & Azure?
> > looking at the modified files It doesn't appear in the list however it seems it is going to be released but not for backported?
>
> oh yeah
Fixed. We release backports for those as well :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RosterIn commented on pull request #14487: Prepare to release the next wave of providers:
Posted by GitBox <gi...@apache.org>.
RosterIn commented on pull request #14487:
URL: https://github.com/apache/airflow/pull/14487#issuecomment-786864419
What about Amazon & Azure?
looking at the modified files It doesn't appear in the list however it seems it is going to be released but not for backported?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14487: Prepare to release the next wave of providers:
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14487:
URL: https://github.com/apache/airflow/pull/14487#issuecomment-787070116
I have no problem with someone else doing it, just not comfortable putting my name as relases manager for something I haven't tested. Reviewing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14487: Prepare to release the next wave of providers:
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14487:
URL: https://github.com/apache/airflow/pull/14487#issuecomment-787076166
> We've never done it before, but Python does have a convention for "this is a doc only changes" `.post1`. I imagine most of our tooling and process works break in such a version though
we could potentially do it this way, but I think there is indeed no harm and almost no cost.
Also there is a benefit for release manager. Next time packages are prepared you will not see those as "potential release candidates" that saves time next time when we prepare release. If only that is a benefit - I would do it anyway.
Alternative to that is mark certain commits (like this one) as "not-worthy-to-be-released" and exclude those when preparing pacakges. Which we might want to do in the future. I think that should be part of bigger change which we might consider. Right now it is release manager who splits the changes to bugs/fixes/doc changes etc. But there was a discussion about using semantic commits or labels for those. We might want to resurrect that discussion (though I think it is perfectly manageable without it for the `providers` - I've done it couple of times and it is very little work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14487: Prepare to release the next wave of providers:
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14487:
URL: https://github.com/apache/airflow/pull/14487#issuecomment-787068154
Refreshed, rebased to latest changes and included all the providers with doc-only changes (this way documentation for them will get also updated ). Once this one passes and we merge, I am happy to cut RCs for all the providers @ashb @kaxil
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #14487: Prepare to release the next wave of providers:
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #14487:
URL: https://github.com/apache/airflow/pull/14487#discussion_r584120215
##########
File path: airflow/providers/docker/CHANGELOG.rst
##########
@@ -19,6 +19,14 @@
Changelog
---------
+1.0.2
+.....
+
+Bug fixes
+~~~~~~~~~
+
+* ``Corrections in docs and tools after releasing provider RCs (#14082)``
Review comment:
Ditto
##########
File path: airflow/providers/apache/hive/CHANGELOG.rst
##########
@@ -19,6 +19,15 @@
Changelog
---------
+1.0.2
+.....
+
+Bug fixes
+~~~~~~~~~
+
+* ``Corrections in docs and tools after releasing provider RCs (#14082)``
Review comment:
Is it actually worth releasing this if it's the only change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RosterIn commented on pull request #14487: Prepare to release the next wave of providers:
Posted by GitBox <gi...@apache.org>.
RosterIn commented on pull request #14487:
URL: https://github.com/apache/airflow/pull/14487#issuecomment-786868719
is it too late for https://github.com/apache/airflow/pull/11015 to be included?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14487: Prepare to release the next wave of providers:
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14487:
URL: https://github.com/apache/airflow/pull/14487#issuecomment-787069205
@ashb if you do not feel ok with it - I am not asking you to approve that one, but I hope this one will not get blocked for too long - there are at least few people who are waiting for the new providers to be released.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14487: Prepare to release the next wave of providers:
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14487:
URL: https://github.com/apache/airflow/pull/14487#issuecomment-786894210
> is it too late for #11015 to be included?
Not too late. I just rebased and regenerated all documents.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14487: Prepare to release the next wave of providers:
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14487:
URL: https://github.com/apache/airflow/pull/14487#issuecomment-787077202
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #14487: Prepare to release the next wave of providers:
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #14487:
URL: https://github.com/apache/airflow/pull/14487#issuecomment-787068154
Refreshed, rebased to latest changes and included all the providers with doc-only changes (this way documentation for them will get also updated ). Once this one passes and we merge, I am happy to cut RCs for all the providers @ashb @kaxil @turbaszek @mik-laj @vikram and others with whom we agreed the release process of 3-weeks cadence of the providers.
I would love to get approval.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #14487: Prepare to release the next wave of providers:
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #14487:
URL: https://github.com/apache/airflow/pull/14487
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #14487: Prepare to release the next wave of providers:
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #14487:
URL: https://github.com/apache/airflow/pull/14487#discussion_r584124051
##########
File path: airflow/providers/apache/hive/CHANGELOG.rst
##########
@@ -19,6 +19,15 @@
Changelog
---------
+1.0.2
+.....
+
+Bug fixes
+~~~~~~~~~
+
+* ``Corrections in docs and tools after releasing provider RCs (#14082)``
Review comment:
I believe so. Since it costs us nothing but it improves the documentation which is released as part of the providers - yes I thought about it yesterday and while I initially excluded them, I think it is definitely worth to release it. It is important to get the updated user documentation in the hands of the users I believe.
It has zero risk, practically no consequences for our users (they will just install newer version when they do). It costs us almost nothing for the batch release.
Yes. I truly believe it is worth to release them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org