[jira] [Commented] (TINKERPOP-1437) Add tests for dedup(Scope) in DedupTest

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15497263#comment-15497263 ] 

ASF GitHub Bot commented on TINKERPOP-1437:
-------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/426

    TINKERPOP-1437 Added tests for dedup(Scope,String...) overload in DedupTest

    https://issues.apache.org/jira/browse/TINKERPOP-1437
    
    Pretty simple - just added a couple of tests - but didn't CTR as I'd feel better with a couple of extra eyes on this as we've had bad tests slip into the suite in the past.  
    
    Runs nicely with `mvn clean install` - doing a `docker/build.sh -t -i -n` now. If anything bad happens I'll post back here.
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1437

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/426.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #426
    
----
commit 9666bb3dc2f593b66095b3e764678ccfc35630a5
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-09-16T20:17:33Z

    Added tests for dedup(Scope,String...) overload in DedupTest

----


> Add tests for dedup(Scope) in DedupTest
> ---------------------------------------
>
>                 Key: TINKERPOP-1437
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1437
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: test-suite
>    Affects Versions: 3.1.4
>            Reporter: stephen mallette
>            Priority: Minor
>
> There are no tests in the test suite that exercise:
> {code}
> public default GraphTraversal<S, E> dedup(final Scope scope, final String... dedupLabels) {
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)