You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Gary Yao (Jira)" <ji...@apache.org> on 2020/04/09 08:24:00 UTC

[jira] [Closed] (FLINK-17047) Simplify SchedulingStrategy#onPartitionConsumable(...) parameters

     [ https://issues.apache.org/jira/browse/FLINK-17047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Yao closed FLINK-17047.
----------------------------
    Resolution: Fixed

master: 
841205cd3afbcff796baf34e98ee7f10b60d29d9
0d21f47a39573f7a3476d5c12a89c1ceb5ffb2b1

> Simplify SchedulingStrategy#onPartitionConsumable(...) parameters
> -----------------------------------------------------------------
>
>                 Key: FLINK-17047
>                 URL: https://issues.apache.org/jira/browse/FLINK-17047
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / Coordination
>    Affects Versions: 1.11.0
>            Reporter: Zhu Zhu
>            Assignee: Zhu Zhu
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.11.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> I'd propose to simplify SchedulingStrategy#onPartitionConsumable(...) parameters as below:
> 1. take IntermediateResultPartitionID instead of ResultPartitionID
>     ResultPartitionID is a composition of IntermediateResultPartitionID and ExecutionAttemptID. SchedulingStrategy is not aware of ExecutionAttemptID so there is no need to expose it.
> 2. drop the executionVertexId param. executionVertexId does not provide extra information. The check in LazyFromSourcesSchedulingStrategy does not make much sense since the executionVertexId is just retrieved by the partitionId in an earlier stage. It makes things more complex since a blocking result partition can become consumable when a vertex who is not its producer finishes.
> This simplification also eases the work of FLINK-14234.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)