[GitHub] [flink-kubernetes-operator] morhidi edited a comment on pull request #38: [FLINK-26181] Support manual savepoint triggering in the operator

[GitBox <gi...@apache.org>]

morhidi edited a comment on pull request #38:
URL: https://github.com/apache/flink-kubernetes-operator/pull/38#issuecomment-1058520122


   > @morhidi what happens when the user simultaneously changes the deployment spec and annotates for savepoint?
   > 
   > Seems like in that case savepointing will be executed immediately after redeploy which will certainly fail, causing the whole update to fail from the operator perspective.
   > 
   > We should clearly define what is the expectation in these cases and add a test case to the controllertest
   
   At first I thought by adding an extra guard `if (!specChanged && SavepointUtils.checkSavepointAnnotation(flinkApp))` would postpone the savepoint creation until we have a running job. It worked but it turned out it is not enough, the tasks should run as well. We can think about this tomorrow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org