[jira] [Commented] (MAPREDUCE-4846) Some JobQueueInfo methods are public in MR1 but protected in MR2

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526098#comment-13526098 ] 

Hadoop QA commented on MAPREDUCE-4846:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12559795/MAPREDUCE-4846.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

      {color:red}-1 javac{color}.  The applied patch generated 2014 javac compiler warnings (more than the trunk's current 2013 warnings).

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3106//testReport/
Javac warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3106//artifact/trunk/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3106//console

This message is automatically generated.
                
> Some JobQueueInfo methods are public in MR1 but protected in MR2
> ----------------------------------------------------------------
>
>                 Key: MAPREDUCE-4846
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4846
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: MAPREDUCE-4846.patch
>
>
> setQueueName, setSchedulingInfo, and setQueueState were public in MR1, but are private int MR2.  They should be made public with InterfaceAudience.Private.
> getQueueState was public, but is now package private.  It has been replaced with getState, which returns a QueueState instead of a String.  It should be made public and deprecated, with a documentation reference to getState.
> Should the other setter methods in JobQueueInfo that were not in MR1 be changed to public/InterfaceAudience.Private for consistency?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira