[GitHub] nifi issue #676: Updating PutAzureEventHub processor so that it uses a parti...

[ijokarumawak <gi...@git.apache.org>]

Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/676
  
    Hello @apsaltis thanks for contributing the PR!
    Excuse us for taking long for you to get any feedback. One reason I guess is that the PR title doesn't have corresponding JIRA number, we usually look for the JIRA having 'patch available' state to review. I searched the JIRA and found [NIFI-2275](https://issues.apache.org/jira/browse/NIFI-2275).
    
    If NIFI-2275 is the right one, please update the PR title, and update the JIRA by clicking the 'Submit Patch' button to proceed the JIRA to patch available state.
    
    I reviewed the code briefly, though. One thing I would like you to update is the name of the new property descriptor, related comment and code. 'Partition Key' and 'Partition Id' are used inconsistent way. I think those all should be 'Partition Key'. It seems the actual partition Id will be determined by EventHubClient library by hashing the partition key.
    
    I wonder if it'd be more useful to support expression language with Partition Key, since the processor accepts incoming flow files, user may want to assign Partition Key based on flow file attributes.
    
    Currently, PutAzureEventHub processor doesn't have Test class. I'd be happy to have one even if it only does simple property checks. It'd be a good starting point and make subsequent contribution easier.
    
    Also, Travis build failed with an unrelated error. Please rebase the branch with the latest master so that it can pass Travis build. 
    
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---