You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/07/21 11:51:04 UTC
[jira] [Commented] (KAFKA-2344) kafka-merge-pr improvements
[ https://issues.apache.org/jira/browse/KAFKA-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634868#comment-14634868 ]
ASF GitHub Bot commented on KAFKA-2344:
---------------------------------------
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/90
KAFKA-2344; kafka-merge-pr improvements
The first 4 commits are adapted from changes that have been done to the Spark version and the last one is the feature that @gwenshap asked for.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka kafka-2344-merge-pr-improvements
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/90.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #90
----
commit 76b58a0e40403071d55389119f9ad5be14e8c8f9
Author: Ismael Juma <is...@juma.me.uk>
Date: 2015-07-21T08:51:17Z
Fix instructions on how to install the `jira-python` library
Adapted from https://github.com/apache/spark/commit/a4df0f2d84ff24318b139db534521141d9d4d593
commit 392623a21bf51f9245ad7958920eba4685536edc
Author: Ismael Juma <is...@juma.me.uk>
Date: 2015-07-21T08:53:17Z
Check return value of doctest.testmod()
Adapted from https://github.com/apache/spark/commit/41afa16500e682475eaa80e31c0434b7ab66abcb
commit da2fd947303a3986bba188d7552b0849c1ac13f8
Author: Ismael Juma <is...@juma.me.uk>
Date: 2015-07-21T08:55:59Z
Set JIRA resolution to "Fixed" instead of relying on default transition
Adapted from:
* https://github.com/apache/spark/commit/1b9e434b6c19f23a01e9875a3c1966cd03ce8e2d
* https://github.com/apache/spark/commit/32e27df412706b30daf41f9d46c5572bb9a41bdb
commit 0d7cb23b6388eb313b7cf74bc5e9357a40ecd1d3
Author: Ismael Juma <is...@juma.me.uk>
Date: 2015-07-21T09:12:13Z
Allow primary author to be overridden during merge
This is useful when multiple people work on a feature and
the automatically chosen default is not the most appropriate
one.
Adapted from:
https://github.com/apache/spark/commit/bc24289f5d54e4ff61cd75a5941338c9d946ff73
https://github.com/apache/spark/commit/228ab65a4eeef8a42eb4713edf72b50590f63176
commit d9b1c684373315d0cdd0cf26264928e9d8974da6
Author: Ismael Juma <is...@juma.me.uk>
Date: 2015-07-21T09:28:41Z
Allow reviewers to be entered during merge
----
> kafka-merge-pr improvements
> ---------------------------
>
> Key: KAFKA-2344
> URL: https://issues.apache.org/jira/browse/KAFKA-2344
> Project: Kafka
> Issue Type: Improvement
> Reporter: Gwen Shapira
> Assignee: Ismael Juma
> Priority: Minor
> Fix For: 0.8.3
>
>
> Two suggestions for the new pr-merge tool:
> * The tool doesn't allow to credit reviewers while committing. I thought the review credits were a nice habit of the Kafka community and I hate losing it. OTOH, I don't want to force-push to trunk just to add credits. Perhaps the tool can ask about committers?
> * Looks like the tool doesn't automatically resolve the JIRA. Would be nice if it did.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)