You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/12 03:37:37 UTC
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request
#4254: remove TableAvailable
terrymanu opened a new pull request #4254: remove TableAvailable
URL: https://github.com/apache/incubator-shardingsphere/pull/4254
For #4250.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4254:
Remove TableAvailable
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4254: Remove TableAvailable
URL: https://github.com/apache/incubator-shardingsphere/pull/4254#issuecomment-585016643
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4254?src=pr&el=h1) Report
> Merging [#4254](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4254?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/ce44ef5ac5d15c38b3a7c4bfe164c5cc8dee7ff6?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `69.23%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4254/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4254?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4254 +/- ##
============================================
+ Coverage 60.92% 60.93% +<.01%
Complexity 352 352
============================================
Files 1011 1011
Lines 16995 16993 -2
Branches 3005 3003 -2
============================================
Hits 10355 10355
Misses 5987 5987
+ Partials 653 651 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4254?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/sql/parser/sql/segment/generic/TableSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4254/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9nZW5lcmljL1RhYmxlU2VnbWVudC5qYXZh) | `20% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...lidator/impl/ShardingInsertStatementValidator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4254/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJvdXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9yb3V0ZS9lbmdpbmUvdmFsaWRhdG9yL2ltcGwvU2hhcmRpbmdJbnNlcnRTdGF0ZW1lbnRWYWxpZGF0b3IuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...l/parser/sql/segment/dml/column/ColumnSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4254/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kbWwvY29sdW1uL0NvbHVtblNlZ21lbnQuamF2YQ==) | `50% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ct/projection/engine/ProjectionsContextEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4254/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXJlbGF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3JlbGF0aW9uL3NlZ21lbnQvc2VsZWN0L3Byb2plY3Rpb24vZW5naW5lL1Byb2plY3Rpb25zQ29udGV4dEVuZ2luZS5qYXZh) | `67.77% <25%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ent/select/projection/engine/ProjectionEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4254/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXJlbGF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3JlbGF0aW9uL3NlZ21lbnQvc2VsZWN0L3Byb2plY3Rpb24vZW5naW5lL1Byb2plY3Rpb25FbmdpbmUuamF2YQ==) | `97.91% <50%> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...rite/token/generator/impl/TableTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4254/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvVGFibGVUb2tlbkdlbmVyYXRvci5qYXZh) | `80.64% <66.66%> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...ere/sharding/route/engine/keygen/GeneratedKey.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4254/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJvdXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9yb3V0ZS9lbmdpbmUva2V5Z2VuL0dlbmVyYXRlZEtleS5qYXZh) | `88.88% <75%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...l/parser/relation/segment/table/TablesContext.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4254/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXJlbGF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3JlbGF0aW9uL3NlZ21lbnQvdGFibGUvVGFibGVzQ29udGV4dC5qYXZh) | `89.65% <87.5%> (+2.98%)` | `0 <0> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4254?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4254?src=pr&el=footer). Last update [ce44ef5...39419bc](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4254?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4254: Remove TableAvailable
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4254: Remove TableAvailable
URL: https://github.com/apache/incubator-shardingsphere/pull/4254#issuecomment-585017536
## Pull Request Test Coverage Report for [Build 1687](https://coveralls.io/builds/28675006)
* **23** of **26** **(88.46%)** changed or added relevant lines in **7** files are covered.
* **2** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.002%**) to **64.833%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-relation/src/main/java/org/apache/shardingsphere/sql/parser/relation/segment/select/projection/engine/ProjectionsContextEngine.java](https://coveralls.io/builds/28675006/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-relation%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Frelation%2Fsegment%2Fselect%2Fprojection%2Fengine%2FProjectionsContextEngine.java#L112) | 1 | 4 | 25.0%
<!-- | **Total:** | **23** | **26** | **88.46%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28675006/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L74) | 2 | 80.0% |
<!-- | **Total:** | **2** | | -->
| Totals | [![Coverage Status](https://coveralls.io/builds/28675006/badge)](https://coveralls.io/builds/28675006) |
| :-- | --: |
| Change from base [Build 9463](https://coveralls.io/builds/28673931): | 0.002% |
| Covered Lines: | 11017 |
| Relevant Lines: | 16993 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4254:
Remove TableAvailable
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4254: Remove TableAvailable
URL: https://github.com/apache/incubator-shardingsphere/pull/4254#issuecomment-585017536
## Pull Request Test Coverage Report for [Build 9464](https://coveralls.io/builds/28674974)
* **23** of **26** **(88.46%)** changed or added relevant lines in **7** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage decreased (**-0.004%**) to **64.827%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-relation/src/main/java/org/apache/shardingsphere/sql/parser/relation/segment/select/projection/engine/ProjectionsContextEngine.java](https://coveralls.io/builds/28674974/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-relation%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Frelation%2Fsegment%2Fselect%2Fprojection%2Fengine%2FProjectionsContextEngine.java#L112) | 1 | 4 | 25.0%
<!-- | **Total:** | **23** | **26** | **88.46%** | -->
| Totals | [![Coverage Status](https://coveralls.io/builds/28674974/badge)](https://coveralls.io/builds/28674974) |
| :-- | --: |
| Change from base [Build 9463](https://coveralls.io/builds/28673931): | -0.004% |
| Covered Lines: | 11016 |
| Relevant Lines: | 16993 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4254:
Remove TableAvailable
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4254: Remove TableAvailable
URL: https://github.com/apache/incubator-shardingsphere/pull/4254
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services