You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/06/30 12:22:27 UTC

[GitHub] [beam] je-ik commented on a change in pull request #15099: [DO NOT MERGE] [BEAM-12539] WIP

je-ik commented on a change in pull request #15099:
URL: https://github.com/apache/beam/pull/15099#discussion_r661409337



##########
File path: sdks/python/apache_beam/io/kafka.py
##########
@@ -96,8 +96,16 @@
      ('commit_offset_in_finalize', bool), ('timestamp_policy', str)])
 
 
-def default_io_expansion_service():
-  return BeamJarExpansionService('sdks:java:io:expansion-service:shadowJar')
+def default_io_expansion_service(args = None):
+  extra_args = None
+  if args:
+    if type(args) != type({}):

Review comment:
       Makes sense, thanks. It is a while since I did actually code in python. :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org