[GitHub] [flink] CrynetLogistics edited a comment on pull request #17345: [FLINK-24227][connectors] FLIP-171: Added Kinesis Data Streams Sink i…

[GitBox <gi...@apache.org>]

CrynetLogistics edited a comment on pull request #17345:
URL: https://github.com/apache/flink/pull/17345#issuecomment-933406220


   Comment From Nuno
   `KinesisDataStreamsSinkConfig`
   Should we change the variable `DEFAULT_MAX_TimeInBufferMS` to `DEFAULT_MAX_TIME_IN_BUFFER_MS`?
   `KinesisDataStreamsSinkITCase`
   Would it be possible to move the following code snippet from runScenario to its own method (like prepareStream )? This method seems a bit large at the moment.
   ```        kinesisClient
                   .createStream(
                           CreateStreamRequest.builder()
                                   .streamName(testStreamName)
                                   .shardCount(1)
                                   .build())
                   .get();
   
           DescribeStreamResponse describeStream =
                   kinesisClient
                           .describeStream(
                                   DescribeStreamRequest.builder().streamName(testStreamName).build())
                           .get();
   ```
   ```
           while (describeStream.streamDescription().streamStatus() != StreamStatus.ACTIVE) {
               describeStream =
                       kinesisClient
                               .describeStream(
                                       DescribeStreamRequest.builder()
                                               .streamName(testStreamName)
                                               .build())
                               .get();
           }
   ```
   In the previous while loop, do we actually need to be creating the describeStream object every time? Would it be possible to have an object with the result of `kinesisClient.describeStream(escribeStreamRequest.builder().streamName(testStreamName).build())` and call `.get().streamDescription().streamStatus()` when want to query the status? Something like:
   `while (<new object>.get().streamDescription().streamStatus() != StreamStatus.ACTIVE);`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org