[GitHub] [fineract] patil-neha-3 opened a new pull request, #3184: Use prepared statements

["patil-neha-3 (via GitHub)" <gi...@apache.org>]

patil-neha-3 opened a new pull request, #3184:
URL: https://github.com/apache/fineract/pull/3184

   ## Description
   
   Changes made as per ticket https://issues.apache.org/jira/browse/FINERACT-854
   
   ## Potential PR improvements
   Adding Unit tests.
   
   If the changes look right will be implementing the same in the below classes
   
   > SmsReadPlatformServiceImpl.java
   > ReportMailingJobReadPlatformServiceImpl.java
   > XBRLResultServiceImpl.java
   
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
   
   - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
   
   - [ ] Create/update unit or integration tests for verifying the changes made.
   
   - [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)
   
   FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] galovics closed pull request #3184: Use prepared statements

["galovics (via GitHub)" <gi...@apache.org>]

galovics closed pull request #3184: Use prepared statements
URL: https://github.com/apache/fineract/pull/3184


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] galovics commented on pull request #3184: Use prepared statements

["galovics (via GitHub)" <gi...@apache.org>]

galovics commented on PR #3184:
URL: https://github.com/apache/fineract/pull/3184#issuecomment-1549476603

   @patil-neha-3 can you pls squash your commits and add tests to this PR to cover the functionality? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] github-actions[bot] commented on pull request #3184: Use prepared statements

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on PR #3184:
URL: https://github.com/apache/fineract/pull/3184#issuecomment-1593875395

   This pull request seems to be stale.  Are you still planning to work on it?  We will automatically close it in 30 days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org