You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/12/16 07:28:10 UTC
Review Request 29089: Fixed the DRFSorter share calculation to not
assume flattened resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29089/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-2099
https://issues.apache.org/jira/browse/MESOS-2099
Repository: mesos-git
Description
-------
We broke the share calculation as soon as we allowed resources to be non-flattened.
Diffs
-----
src/master/drf_sorter.cpp 0ad6c52759e1ceec4b43f99d8fa1e75d7e2e1c31
src/tests/sorter_tests.cpp 0516ab573d9f4f2af249978e15ebf52c2afb5359
Diff: https://reviews.apache.org/r/29089/diff/
Testing
-------
Added a test.
Thanks,
Ben Mahler
Re: Review Request 29089: Fixed the DRFSorter share calculation to not
assume flattened resources.
Posted by Ben Mahler <be...@gmail.com>.
> On Dec. 16, 2014, 9:55 p.m., Jie Yu wrote:
> > src/tests/sorter_tests.cpp, lines 182-183
> > <https://reviews.apache.org/r/29089/diff/1/?file=792870#file792870line182>
> >
> > Consider using ```createDiskInfo``` in src/test/mesos.hpp?
Good idea, although given mesos.hpp is largely a header leveraged by the integration tests, could we move it to src/test/utils.hpp?
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29089/#review65246
-----------------------------------------------------------
On Dec. 16, 2014, 6:28 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29089/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2014, 6:28 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-2099
> https://issues.apache.org/jira/browse/MESOS-2099
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> We broke the share calculation as soon as we allowed resources to be non-flattened.
>
>
> Diffs
> -----
>
> src/master/drf_sorter.cpp 0ad6c52759e1ceec4b43f99d8fa1e75d7e2e1c31
> src/tests/sorter_tests.cpp 0516ab573d9f4f2af249978e15ebf52c2afb5359
>
> Diff: https://reviews.apache.org/r/29089/diff/
>
>
> Testing
> -------
>
> Added a test.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 29089: Fixed the DRFSorter share calculation to not
assume flattened resources.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29089/#review65246
-----------------------------------------------------------
Ship it!
src/tests/sorter_tests.cpp
<https://reviews.apache.org/r/29089/#comment108294>
Can you move this line down and include disk1 and disk2 so that you test the calculation of hte 'total' part as well.
```
sorter.add(Resources::parse("...").get() + disk1 + disk2);
```
src/tests/sorter_tests.cpp
<https://reviews.apache.org/r/29089/#comment108297>
Consider using ```createDiskInfo``` in src/test/mesos.hpp?
- Jie Yu
On Dec. 16, 2014, 6:28 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29089/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2014, 6:28 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-2099
> https://issues.apache.org/jira/browse/MESOS-2099
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> We broke the share calculation as soon as we allowed resources to be non-flattened.
>
>
> Diffs
> -----
>
> src/master/drf_sorter.cpp 0ad6c52759e1ceec4b43f99d8fa1e75d7e2e1c31
> src/tests/sorter_tests.cpp 0516ab573d9f4f2af249978e15ebf52c2afb5359
>
> Diff: https://reviews.apache.org/r/29089/diff/
>
>
> Testing
> -------
>
> Added a test.
>
>
> Thanks,
>
> Ben Mahler
>
>