You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/08/31 03:53:53 UTC
[GitHub] [yunikorn-k8shim] lowc1012 opened a new pull request, #454: [YUNIKORN-1296] do not run e2e-tests unless build passes
lowc1012 opened a new pull request, #454:
URL: https://github.com/apache/yunikorn-k8shim/pull/454
### What is this PR for?
1. add needs: build configuration into e2e-tests job
2. create a push-to-master wf
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
[YUNIKORN-1296](https://issues.apache.org/jira/browse/YUNIKORN-1296)
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit closed pull request #454: [YUNIKORN-1296] do not run e2e-tests unless build passes
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #454: [YUNIKORN-1296] do not run e2e-tests unless build passes
URL: https://github.com/apache/yunikorn-k8shim/pull/454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #454: [YUNIKORN-1296] do not run e2e-tests unless build passes
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #454:
URL: https://github.com/apache/yunikorn-k8shim/pull/454#issuecomment-1232435218
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#454](https://codecov.io/gh/apache/yunikorn-k8shim/pull/454?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ea9c3b5) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/824351f0b2c345fddca122a6c3f6ad69353facb4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (824351f) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #454 +/- ##
=======================================
Coverage 67.00% 67.00%
=======================================
Files 41 41
Lines 6767 6767
=======================================
Hits 4534 4534
Misses 2062 2062
Partials 171 171
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] wilfred-s commented on pull request #454: [YUNIKORN-1296] do not run e2e-tests unless build passes
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on PR #454:
URL: https://github.com/apache/yunikorn-k8shim/pull/454#issuecomment-1232552347
Based on the workflow log the change has worked for the dependency:
![image](https://user-images.githubusercontent.com/7152971/187616363-ce815b85-5960-45d4-9e1d-732f552aafc8.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org