You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/05/07 06:23:56 UTC
[GitHub] [iotdb] cmlmakahts commented on a diff in pull request #5811: [IOTDB-2919] Feature/Delete storage group
cmlmakahts commented on code in PR #5811:
URL: https://github.com/apache/iotdb/pull/5811#discussion_r867311451
##########
thrift-confignode/src/main/thrift/confignode.thrift:
##########
@@ -53,8 +53,8 @@ struct TSetStorageGroupReq {
1: required TStorageGroupSchema storageGroup
}
-struct TDeleteStorageGroupReq {
- 1: required string storageGroup
+struct TDeleteStorageGroupsReq {
+ 1: required list<string> prefixPathList
Review Comment:
Because there is only _deleteStorageGroups_ in the rpc interface at previous version, so I just restore it as it is in previous. Should I implement the interface of delete a single storage group besides as we discussed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org