You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Brett Porter (JIRA)" <ji...@codehaus.org> on 2005/06/20 03:03:52 UTC

[jira] Created: (MNG-493) allow executions with no id

allow executions with no id
---------------------------

         Key: MNG-493
         URL: http://jira.codehaus.org/browse/MNG-493
     Project: Maven 2
        Type: Bug
  Components: maven-project  
    Reporter: Brett Porter
 Assigned to: John Casey 
     Fix For: 2.0-alpha-3


currently, the following doesn't pick up the execution configuration:
<plugin>
        <groupId>org.codehaus.modello</groupId>
        <artifactId>modello-maven-plugin</artifactId>
        <version>1.0-alpha-3-SNAPSHOT</version>
        <executions>
          <execution>
            <configuration>
              <version>1.0.0</version>
              <packageWithVersion>false</packageWithVersion>
              <model>src/main/resources/continuum.mdo</model>
            </configuration>
            <goals>
              <goal>java</goal>
              <goal>jpox-jdo-mapping</goal>
              <goal>jpox-store</goal>
            </goals>
          </execution>
        </executions>
      </plugin>

When an id is added, the configuration is picked up. I assume this slipped through because the original spec called for an id on the execution.

Requiring an id is probably too strict. What we should do is make id optional (as it is), honour it as an execution, and its configuration, but not merge it with any other executions with or without an id (so they would all just be added as new executions in inheritence).



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MNG-493) allow executions with no id

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-493?page=all ]
     
John Casey closed MNG-493:
--------------------------

    Resolution: Fixed

got one follow-on commit coming to fix a subtle bug with the expression of the execution-id collisions, and this is finished.

> allow executions with no id
> ---------------------------
>
>          Key: MNG-493
>          URL: http://jira.codehaus.org/browse/MNG-493
>      Project: Maven 2
>         Type: Bug
>   Components: maven-project
>     Reporter: Brett Porter
>     Assignee: John Casey
>      Fix For: 2.0-alpha-3

>
>
> currently, the following doesn't pick up the execution configuration:
> <plugin>
>         <groupId>org.codehaus.modello</groupId>
>         <artifactId>modello-maven-plugin</artifactId>
>         <version>1.0-alpha-3-SNAPSHOT</version>
>         <executions>
>           <execution>
>             <configuration>
>               <version>1.0.0</version>
>               <packageWithVersion>false</packageWithVersion>
>               <model>src/main/resources/continuum.mdo</model>
>             </configuration>
>             <goals>
>               <goal>java</goal>
>               <goal>jpox-jdo-mapping</goal>
>               <goal>jpox-store</goal>
>             </goals>
>           </execution>
>         </executions>
>       </plugin>
> When an id is added, the configuration is picked up. I assume this slipped through because the original spec called for an id on the execution.
> Requiring an id is probably too strict. What we should do is make id optional (as it is), honour it as an execution, and its configuration, but not merge it with any other executions with or without an id (so they would all just be added as new executions in inheritence).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org