You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2010/08/25 23:20:16 UTC

[jira] Created: (MAPREDUCE-2034) TestSubmitJob triggers NPE instead of permissions error

TestSubmitJob triggers NPE instead of permissions error
-------------------------------------------------------

                 Key: MAPREDUCE-2034
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2034
             Project: Hadoop Map/Reduce
          Issue Type: Test
          Components: test
    Affects Versions: 0.22.0
            Reporter: Todd Lipcon
            Assignee: Todd Lipcon
            Priority: Trivial


TestSubmitJob.testSecureJobExecution catches _any_ IOException and assumes a permissions error has been caught. In fact, it was passing an invalid path name to the NameNode and triggering an NPE, not a Permission denied error, in one case, but the test was not specific enough to detect this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (MAPREDUCE-2034) TestSubmitJob triggers NPE instead of permissions error

Posted by "Tom White (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927191#action_12927191 ] 

Tom White commented on MAPREDUCE-2034:
--------------------------------------

+1 looks good. Can you run test-patch for it?

> TestSubmitJob triggers NPE instead of permissions error
> -------------------------------------------------------
>
>                 Key: MAPREDUCE-2034
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2034
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Trivial
>         Attachments: mapreduce-2034.txt
>
>
> TestSubmitJob.testSecureJobExecution catches _any_ IOException and assumes a permissions error has been caught. In fact, it was passing an invalid path name to the NameNode and triggering an NPE, not a Permission denied error, in one case, but the test was not specific enough to detect this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (MAPREDUCE-2034) TestSubmitJob triggers NPE instead of permissions error

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated MAPREDUCE-2034:
-----------------------------------

    Status: Patch Available  (was: Open)

Patch fixes the test to actually look for a "Permission denied" IOE, and then fixes the getListing call itself to just pass a path instead of the whole URL - it was previously passing hdfs://... which generated an assertion failure on the NN side (or an NPE in 0.20).

> TestSubmitJob triggers NPE instead of permissions error
> -------------------------------------------------------
>
>                 Key: MAPREDUCE-2034
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2034
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Trivial
>         Attachments: mapreduce-2034.txt
>
>
> TestSubmitJob.testSecureJobExecution catches _any_ IOException and assumes a permissions error has been caught. In fact, it was passing an invalid path name to the NameNode and triggering an NPE, not a Permission denied error, in one case, but the test was not specific enough to detect this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (MAPREDUCE-2034) TestSubmitJob triggers NPE instead of permissions error

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated MAPREDUCE-2034:
-----------------------------------

    Attachment: mapreduce-2034.txt

> TestSubmitJob triggers NPE instead of permissions error
> -------------------------------------------------------
>
>                 Key: MAPREDUCE-2034
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2034
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Trivial
>         Attachments: mapreduce-2034.txt
>
>
> TestSubmitJob.testSecureJobExecution catches _any_ IOException and assumes a permissions error has been caught. In fact, it was passing an invalid path name to the NameNode and triggering an NPE, not a Permission denied error, in one case, but the test was not specific enough to detect this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.