You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by dc...@apache.org on 2021/12/20 20:07:14 UTC

[datasketches-memory] 02/03: Remove module-info and replace with compiler add-modules

This is an automated email from the ASF dual-hosted git repository.

dcromberge pushed a commit to branch Jdk17_Panama_David
in repository https://gitbox.apache.org/repos/asf/datasketches-memory.git

commit 87246a7ed1d3aaddf4ec201ff7e7e69b3ec3f2a7
Author: David Cromberge <dc...@apache.org>
AuthorDate: Mon Dec 20 19:47:26 2021 +0000

    Remove module-info and replace with compiler add-modules
---
 datasketches-memory-java17/pom.xml                 | 27 ++++++++++++++++++++++
 .../src/main/java/module-info.java                 | 26 ---------------------
 2 files changed, 27 insertions(+), 26 deletions(-)

diff --git a/datasketches-memory-java17/pom.xml b/datasketches-memory-java17/pom.xml
index 2a24576..10f7206 100644
--- a/datasketches-memory-java17/pom.xml
+++ b/datasketches-memory-java17/pom.xml
@@ -28,6 +28,15 @@
         <version>2.1.0-SNAPSHOT</version>
     </parent>
 
+    <dependencies>
+        <dependency>
+            <groupId>org.apache.datasketches</groupId>
+            <artifactId>datasketches-memory-java8</artifactId>
+            <version>${project.version}</version>
+            <scope>provided</scope>
+        </dependency>
+    </dependencies>
+
     <artifactId>datasketches-memory-java17</artifactId>
     <name>${project.artifactId}</name>
     <packaging>jar</packaging>
@@ -39,4 +48,22 @@
         <maven.compiler.target>${java.version}</maven.compiler.target>
     </properties>
 
+    <build>
+        <pluginManagement>
+            <plugins>
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-compiler-plugin</artifactId>
+                    <version>${maven-compiler-plugin.version}</version>
+                    <configuration>
+                        <compilerArgs>
+                            <arg>--add-modules</arg>
+                            <arg>jdk.incubator.foreign</arg>
+                        </compilerArgs>
+                    </configuration>
+                </plugin>
+            </plugins>
+        </pluginManagement>
+    </build>
+
 </project>
diff --git a/datasketches-memory-java17/src/main/java/module-info.java b/datasketches-memory-java17/src/main/java/module-info.java
deleted file mode 100644
index ed6cf80..0000000
--- a/datasketches-memory-java17/src/main/java/module-info.java
+++ /dev/null
@@ -1,26 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-@SuppressWarnings("javadoc")
-module org.apache.datasketches.memory {
-    requires java.base;
-    requires java.logging;
-    requires jdk.unsupported;
-    requires jdk.incubator.foreign;
-    exports org.apache.datasketches.memory.internal;
-}

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org