DO NOT REPLY [Bug 41190] New: - mod_rewrite stats the wrong file when using sdbm maps

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41190>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41190

           Summary: mod_rewrite stats the wrong file when using sdbm maps
           Product: Apache httpd-2
           Version: 2.2.3
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: mod_rewrite
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: nikke@acc.umu.se


When using an sdbm map mod_rewrite stats the wrong file when checking for
freshness, it stats the .dir file (that seldom changes) instead of the .pag file.

The problem lies in the fact that cmd_rewritemap() ignores the second value
returned from apr_dbm_get_usednames_ex. The only dbm type that uses the second
value is sdbm, and it's always the .pag file.

There are multiple things to consider to solve this, which is why I won't
provide a patch. I'll give my point of view though:

It should be documented which file returned from apr_dbm_get_usednames_ex is the
one to check freshness, I'd suggest that this be the first value and that
apr-util/dbm/apr_dbm_sdbm.c is fixed to follow this (it's the only one returning
two values).

Or you can document that the second value is the file to check for freshness and
fix mod_rewrite.c. This would be the most backwards compatible solution as it
would not require an updated apr-utils when not using the httpd-bundled apr-utils.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org