[GitHub] [zeppelin] alexott commented on a change in pull request #3772: [ZEPPELIN-4805]. Error Stack Trace not received on rest API

[GitBox <gi...@apache.org>]

alexott commented on a change in pull request #3772:
URL: https://github.com/apache/zeppelin/pull/3772#discussion_r425592000



##########
File path: zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java
##########
@@ -279,6 +279,22 @@ public Note importNote(String notePath,
     }
   }
 
+  /**
+   * Return true only when paragraph execution finished, it could end with succeed or error due to user code.
+   * Return false when paragraph execution fails due to zeppelin internal issue.
+   * @param noteId
+   * @param paragraphId
+   * @param title
+   * @param text
+   * @param params
+   * @param config
+   * @param failIfDisabled
+   * @param blocking
+   * @param context
+   * @param callback
+   * @return

Review comment:
       should we move "return true only when ..." here and at beginning something like "executes given paragraph"...?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org