You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/07/20 14:36:07 UTC
[GitHub] [lucene] mocobeta opened a new pull request #218: LUCENE-9855: Rename knn search vector format
mocobeta opened a new pull request #218:
URL: https://github.com/apache/lucene/pull/218
This is the second attempt to rename the nearest-neighbor vector search format.
Changes in o.a.l.codec package:
- rename VectorFormat to KnnVectorsVormat, VectorReader to KnnVectorsReader, and VectorWriter to KnnVectorsWriter
- rename Lucene90HnswVectorFormat to Lucene90HnswVectorsFormat (the SPI name was also changed), Lucene90HnswVectorReader to Lucene90HnswVectorsReader, and Lucene90HnswVectorWriter to Lucene90HnswVectorsWriter
- rename PerFieldVectorFormat to PefFieldNnVectorsFormat
Changes in o.a.l.document package:
- rename VectorField to KnnVectorField
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jtibshirani commented on a change in pull request #218: LUCENE-9855: Rename knn search vector format
Posted by GitBox <gi...@apache.org>.
jtibshirani commented on a change in pull request #218:
URL: https://github.com/apache/lucene/pull/218#discussion_r675390470
##########
File path: lucene/core/src/java/org/apache/lucene/document/KnnVectorField.java
##########
@@ -26,13 +26,13 @@
* an array (of type float[]) whose length is the vector dimension. Values can be retrieved using
* {@link VectorValues}, which is a forward-only docID-based iterator and also offers random-access
* by dense ordinal (not docId). VectorValues.SearchSimlarity may be used to compare vectors at
Review comment:
Not really related to this PR, but maybe we could fix this outdated reference to `VectorValues.SearchSimilarity`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta merged pull request #218: LUCENE-9855: Rename knn search vector format
Posted by GitBox <gi...@apache.org>.
mocobeta merged pull request #218:
URL: https://github.com/apache/lucene/pull/218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a change in pull request #218: LUCENE-9855: Rename knn search vector format
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #218:
URL: https://github.com/apache/lucene/pull/218#discussion_r674908384
##########
File path: lucene/CHANGES.txt
##########
@@ -7,7 +7,7 @@ http://s.apache.org/luceneversions
New Features
-* LUCENE-9322: Vector-valued fields, Lucene90 Codec (Mike Sokolov, Julie Tibshirani, Tomoko Uchida)
+* LUCENE-9322 LUCENE-9855: Vector-valued fields, Lucene90 Codec (Mike Sokolov, Julie Tibshirani, Tomoko Uchida)
* LUCENE-9004: Approximate nearest vector search via NSW graphs
Review comment:
Thanks, I'll add the credit on this pr.
Actually, I cannot identify who are supposed to be listed here since so many people were involved (though I know your name should be firstly credited)... please let me know if there are other outstanding contributors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #218: LUCENE-9855: Rename knn search vector format
Posted by GitBox <gi...@apache.org>.
mocobeta commented on pull request #218:
URL: https://github.com/apache/lucene/pull/218#issuecomment-885343046
Thanks, @msokolov for your comment.
I'll wait for feedback from others (if there are further suggestions) for a while before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #218: LUCENE-9855: Rename knn search vector format
Posted by GitBox <gi...@apache.org>.
mocobeta commented on pull request #218:
URL: https://github.com/apache/lucene/pull/218#issuecomment-885990889
Thanks for reviewing!
I've been away for quite a while from the new codec/feature, this work was a good refresher to me...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] msokolov commented on a change in pull request #218: LUCENE-9855: Rename knn search vector format
Posted by GitBox <gi...@apache.org>.
msokolov commented on a change in pull request #218:
URL: https://github.com/apache/lucene/pull/218#discussion_r675162465
##########
File path: lucene/CHANGES.txt
##########
@@ -7,7 +7,7 @@ http://s.apache.org/luceneversions
New Features
-* LUCENE-9322: Vector-valued fields, Lucene90 Codec (Mike Sokolov, Julie Tibshirani, Tomoko Uchida)
+* LUCENE-9322 LUCENE-9855: Vector-valued fields, Lucene90 Codec (Mike Sokolov, Julie Tibshirani, Tomoko Uchida)
* LUCENE-9004: Approximate nearest vector search via NSW graphs
Review comment:
Yeah I looked at the discussion on the issue, and there were lots of folks weighing in there with helpful contributions, but given there were so many, and as far as I can remember only the two of us actually contributed any code, I'd just list us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] msokolov commented on a change in pull request #218: LUCENE-9855: Rename knn search vector format
Posted by GitBox <gi...@apache.org>.
msokolov commented on a change in pull request #218:
URL: https://github.com/apache/lucene/pull/218#discussion_r674861123
##########
File path: lucene/CHANGES.txt
##########
@@ -7,7 +7,7 @@ http://s.apache.org/luceneversions
New Features
-* LUCENE-9322: Vector-valued fields, Lucene90 Codec (Mike Sokolov, Julie Tibshirani, Tomoko Uchida)
+* LUCENE-9322 LUCENE-9855: Vector-valued fields, Lucene90 Codec (Mike Sokolov, Julie Tibshirani, Tomoko Uchida)
* LUCENE-9004: Approximate nearest vector search via NSW graphs
Review comment:
I think you and I were mostly working on it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a change in pull request #218: LUCENE-9855: Rename knn search vector format
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #218:
URL: https://github.com/apache/lucene/pull/218#discussion_r674908384
##########
File path: lucene/CHANGES.txt
##########
@@ -7,7 +7,7 @@ http://s.apache.org/luceneversions
New Features
-* LUCENE-9322: Vector-valued fields, Lucene90 Codec (Mike Sokolov, Julie Tibshirani, Tomoko Uchida)
+* LUCENE-9322 LUCENE-9855: Vector-valued fields, Lucene90 Codec (Mike Sokolov, Julie Tibshirani, Tomoko Uchida)
* LUCENE-9004: Approximate nearest vector search via NSW graphs
Review comment:
Thanks, I'll add the credit on this pr.
Actually, I cannot identify who is supposed to be listed here since so many people were involved (though I know your name should be firstly credited)... please let me know if there are other outstanding contributors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a change in pull request #218: LUCENE-9855: Rename knn search vector format
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #218:
URL: https://github.com/apache/lucene/pull/218#discussion_r675933594
##########
File path: lucene/core/src/java/org/apache/lucene/document/KnnVectorField.java
##########
@@ -26,13 +26,13 @@
* an array (of type float[]) whose length is the vector dimension. Values can be retrieved using
* {@link VectorValues}, which is a forward-only docID-based iterator and also offers random-access
* by dense ordinal (not docId). VectorValues.SearchSimlarity may be used to compare vectors at
Review comment:
Thanks, I've not noticed this. Will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a change in pull request #218: LUCENE-9855: Rename knn search vector format
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #218:
URL: https://github.com/apache/lucene/pull/218#discussion_r673219671
##########
File path: lucene/CHANGES.txt
##########
@@ -7,7 +7,7 @@ http://s.apache.org/luceneversions
New Features
-* LUCENE-9322: Vector-valued fields, Lucene90 Codec (Mike Sokolov, Julie Tibshirani, Tomoko Uchida)
+* LUCENE-9322 LUCENE-9855: Vector-valued fields, Lucene90 Codec (Mike Sokolov, Julie Tibshirani, Tomoko Uchida)
* LUCENE-9004: Approximate nearest vector search via NSW graphs
Review comment:
off-topic: this has no credit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org