You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/09/14 02:46:51 UTC
[GitHub] [incubator-linkis] binbinCheng opened a new pull request, #3356: linkis-common module errorcode optimization and documentation
binbinCheng opened a new pull request, #3356:
URL: https://github.com/apache/incubator-linkis/pull/3356
linkis-common module errorcode optimization and documentation
Related issues: https://github.com/apache/incubator-linkis/issues/3355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #3356: linkis-common module errorcode optimization and documentation
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #3356:
URL: https://github.com/apache/incubator-linkis/pull/3356#issuecomment-1246391485
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/3356?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3356](https://codecov.io/gh/apache/incubator-linkis/pull/3356?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cce92c7) into [dev-1.3.1](https://codecov.io/gh/apache/incubator-linkis/commit/92921e9eb03f5694253307ca0ec534b37f61ee9f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (92921e9) will **increase** coverage by `0.09%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## dev-1.3.1 #3356 +/- ##
===============================================
+ Coverage 13.65% 13.75% +0.09%
- Complexity 1424 1434 +10
===============================================
Files 899 900 +1
Lines 31094 31109 +15
Branches 4483 4478 -5
===============================================
+ Hits 4245 4278 +33
+ Misses 26299 26281 -18
Partials 550 550
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/3356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ommon/errorcode/LinkisCommonsErrorCodeSummary.java](https://codecov.io/gh/apache/incubator-linkis/pull/3356/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL2NvbW1vbi9lcnJvcmNvZGUvTGlua2lzQ29tbW9uc0Vycm9yQ29kZVN1bW1hcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...e/LinkisComputationGovernanceErrorCodeSummary.java](https://codecov.io/gh/apache/incubator-linkis/pull/3356/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL2NvbW1vbi9lcnJvcmNvZGUvTGlua2lzQ29tcHV0YXRpb25Hb3Zlcm5hbmNlRXJyb3JDb2RlU3VtbWFyeS5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...inkis/common/errorcode/LinkisErrorCodeSummary.java](https://codecov.io/gh/apache/incubator-linkis/pull/3356/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL2NvbW1vbi9lcnJvcmNvZGUvTGlua2lzRXJyb3JDb2RlU3VtbWFyeS5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../common/errorcode/LinkisFrameErrorCodeSummary.java](https://codecov.io/gh/apache/incubator-linkis/pull/3356/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL2NvbW1vbi9lcnJvcmNvZGUvTGlua2lzRnJhbWVFcnJvckNvZGVTdW1tYXJ5LmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...he/linkis/governance/common/paser/CodeParser.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3356/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UtY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGlua2lzL2dvdmVybmFuY2UvY29tbW9uL3Bhc2VyL0NvZGVQYXJzZXIuc2NhbGE=) | `23.75% <0.00%> (-0.27%)` | :arrow_down: |
| [.../main/java/org/apache/linkis/common/io/FsPath.java](https://codecov.io/gh/apache/incubator-linkis/pull/3356/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL2NvbW1vbi9pby9Gc1BhdGguamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...cala/org/apache/linkis/rpc/RPCReceiveRestful.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3356/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXJwYy9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9ycGMvUlBDUmVjZWl2ZVJlc3RmdWwuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [.../org/apache/linkis/rpc/transform/RPCConsumer.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3356/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXJwYy9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9ycGMvdHJhbnNmb3JtL1JQQ0NvbnN1bWVyLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...anager/engineplugin/jdbc/utils/JdbcParamUtils.java](https://codecov.io/gh/apache/incubator-linkis/pull/3356/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9qZGJjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saW5raXMvbWFuYWdlci9lbmdpbmVwbHVnaW4vamRiYy91dGlscy9KZGJjUGFyYW1VdGlscy5qYXZh) | `65.90% <0.00%> (ø)` | |
| [...s/governance/common/conf/GovernaceCommonConf.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3356/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UtY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGlua2lzL2dvdmVybmFuY2UvY29tbW9uL2NvbmYvR292ZXJuYWNlQ29tbW9uQ29uZi5zY2FsYQ==) | `96.42% <0.00%> (+0.13%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/incubator-linkis/pull/3356/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone merged pull request #3356: linkis-common module errorcode optimization and documentation
Posted by GitBox <gi...@apache.org>.
casionone merged PR #3356:
URL: https://github.com/apache/incubator-linkis/pull/3356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #3356: linkis-common module errorcode optimization and documentation
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #3356:
URL: https://github.com/apache/incubator-linkis/pull/3356#discussion_r970302223
##########
linkis-commons/linkis-common/src/main/java/org/apache/linkis/common/errorcode/LinkisCommonsErrorCodeSummary.java:
##########
@@ -18,7 +18,8 @@
package org.apache.linkis.common.errorcode;
public enum LinkisCommonsErrorCodeSummary {
- ENGINE_FAILED_STARTED(11000, "引擎启动失败", "引擎启动失败", "hiveEngineConn");
+ ENGINE_FAILED_STARTED(
+ 11000, "(Engine start failed引擎启动失败)", "Engine start failed(引擎启动失败)", "hiveEngineConn");
Review Comment:
"Engine start failed(引擎启动失败)"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org