You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tamas Mate (Code Review)" <ge...@cloudera.org> on 2023/03/06 12:43:37 UTC
[native-toolchain-CR] IMPALA-11949: Add AVRO C++ 1.11.1 version
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19546 )
Change subject: IMPALA-11949: Add AVRO C++ 1.11.1 version
......................................................................
Patch Set 1:
(1 comment)
Thank you for the review Laszlo!
http://gerrit.cloudera.org:8080/#/c/19546/1/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/19546/1/buildall.sh@297
PS1, Line 297: export BOOST_VERSION=1.74.0-p1
> Nit: just wondering: is there a reason why BOOST_VERSION cannot be passed i
The only reason I did it like this because this is how dependency versions are passed to other applications as well. I assumed that it is to avoid setting a version unexpectedly for other applications.
--
To view, visit http://gerrit.cloudera.org:8080/19546
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I307247cdf19ea8b9a97248624111bdaa05dd8496
Gerrit-Change-Number: 19546
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Mar 2023 12:43:37 +0000
Gerrit-HasComments: Yes