You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Eduard Tudenhoefner (Jira)" <ji...@apache.org> on 2020/04/02 10:55:00 UTC
[jira] [Comment Edited] (CASSANDRA-15659) Better support of Python
3 for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-15659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073545#comment-17073545 ]
Eduard Tudenhoefner edited comment on CASSANDRA-15659 at 4/2/20, 10:54 AM:
---------------------------------------------------------------------------
I relaxed the requirement of *cqlsh* only working with Python 2.7 & 3.6 by allowing Python 3.6+.
Note that I left the constraint for Python 3.6 being the minimum Python3 version.
As [~ptbannister] pointed out, we could remove the Python 3.6 min version once we remove Python 2.7 support, as otherwise testing with lots of different Python versions will get costly.
I also added 2 Dockerfiles in *pylib* for minimal local testing of *cqlsh* starting up with Python 3.7 & 3.8 and that both revealed
CASSANDRA-15572 and CASSANDRA-15573.
I fixed CASSANDRA-15572 in my branch as it was a one-liner. And I'm going to tackle CASSANDRA-15573 later.
I also added Python 3.8 testing to the CircleCI config so that we can actually see what else breaks with newer Python versions.
Update:
I tried running things with my CircleCI config changes and Python 3.8 in https://app.circleci.com/pipelines/github/nastra/cassandra/jobs/106 but it seems the Docker image we're using has only Python 2.7&3.6 installed
[~spod] would we need new Docker images that have Python 3.8 installed in order to be able to test with Python 3.6 + 3.8? What's the process for that? Any help/hint would be appreciated.
was (Author: eduard.tudenhoefner):
I relaxed the requirement of *cqlsh* only working with Python 2.7 & 3.6 by allowing Python 3.6+.
Note that I left the constraint for Python 3.6 being the minimum Python3 version.
As [~ptbannister] pointed out, we could remove the Python 3.6 min version once we remove Python 2.7 support, as otherwise testing with lots of different Python versions will get costly.
I also added 2 Dockerfiles in *pylib* for minimal local testing of *cqlsh* starting up with Python 3.7 & 3.8 and that both revealed
CASSANDRA-15572 and CASSANDRA-15573.
I fixed CASSANDRA-15572 in my branch as it was a one-liner. And I'm going to tackle CASSANDRA-15573 later.
I also added Python 3.8 testing to the CircleCI config so that we can actually see what else breaks with newer Python versions.
> Better support of Python 3 for cqlsh
> ------------------------------------
>
> Key: CASSANDRA-15659
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15659
> Project: Cassandra
> Issue Type: Task
> Components: Tool/cqlsh
> Reporter: Stefan Miklosovic
> Assignee: Eduard Tudenhoefner
> Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0-alpha
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> From mailing list:
> [https://lists.apache.org/thread.html/r377099b632c62b641e4feef5b738084fc5369b0c7157fae867853597%40%3Cdev.cassandra.apache.org%3E]
>
> As of today (24/3/2020) and current trunk, there is Python 3.6 supported (1) but there is not any 3.6 version ootb in Debian for example. E.g. Buster has Python 3.7 and other (recent) releases have version 2.7. This means that if one wants to use Python 3 in Debian, he has to use 3.6 but it is not in the repository so he has to download / compile / install it on his own.
> There should be some sane Python 3 version supported which is as well present in Debian repository (or requirement to run with 3.6 should be relaxed) .
> (1) [https://github.com/apache/cassandra/blob/bf9a1d487b9ba469e8d740cf7d1cd419535a7e79/bin/cqlsh#L57-L65]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org