You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/09/06 14:22:43 UTC

[GitHub] [rocketmq-client-go] murDDock removed a comment on pull request #516: fix(remotingClient):avoid goroutine leak

murDDock removed a comment on pull request #516:
URL: https://github.com/apache/rocketmq-client-go/pull/516#issuecomment-687802886


   > @murDDock why not select case <-r.ctx.Done() instead of recover from panic?
   
    select case <-r.ctx.Done()  won't solve the problem which is caused by bloking by responseFuture.Done.
   
   But it seems that recover from panic seems not quite elegant. 
   
   Maybe we coule close "responseFuture.Done" or make it non-blocking ， let me push  another solution tomorrow.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org