[GitHub] [pulsar] wolfstudy commented on a change in pull request #8365: [Go functions] Provide pre-start access to secrets and conf

[GitBox <gi...@apache.org>]

wolfstudy commented on a change in pull request #8365:
URL: https://github.com/apache/pulsar/pull/8365#discussion_r516380304



##########
File path: pulsar-function-go/pf/context.go
##########
@@ -119,6 +118,15 @@ func (c *FunctionContext) GetUserConfMap() map[string]interface{} {
 	return c.userConfigs
 }
 
+func (c *FunctionContext) GetSecretsMap() map[string]interface{} {

Review comment:
       @flowchartsman As we discussed, we can separate this pr and provide the secretsProvider interface to allow users to customize their own encryption methods. By default, we can provide an implementation of reading secrets from environment variables. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org