[jira] [Resolved] (OAK-562) Clean up duplicate name conversion in plugins/nodetype

["Jukka Zitting (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting resolved OAK-562.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 0.6
         Assignee: Jukka Zitting

In revision 1434640 I moved the classes related to type registration to a new o.a.j.o.plugins.nodetype.write subpackage for better encapsulation (only ReadWriteNTM and InitialContent are public).

That should cover everything for this issue, so resolving as fixed.
                
> Clean up duplicate name conversion in plugins/nodetype
> ------------------------------------------------------
>
>                 Key: OAK-562
>                 URL: https://issues.apache.org/jira/browse/OAK-562
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: angela
>            Assignee: Jukka Zitting
>             Fix For: 0.6
>
>         Attachments: 0001-OAK-562-Clean-up-duplicate-name-conversion-in-plugin.patch, 0001-OAK-562-Clean-up-duplicate-name-conversion-in-plugin.patch
>
>
> the following two lines are omnipresent in the node type package:
> JcrNameParser.checkName(name, true);
> this.name = mapper.getJcrName(mapper.getOakNameOrNull(name));
> as discussed in OAK-553 this is quite troublesome as getJcrName expects
> a null oak name parameter and in addition looks odd.
> possibles solutions include:
> - refactoring this to a new method in the NameMapper (getNormalizedJcrName)
> - refactor the code such that the node type related implementations
>   keep oak-names internally and convert them to the standard jcr-form
>   on demand.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira