[GitHub] XD-DENG edited a comment on issue #4309: [AIRFLOW-3504] Extend/refine the functionality of "/health" endpoint

[GitBox <gi...@apache.org>]

XD-DENG edited a comment on issue #4309: [AIRFLOW-3504] Extend/refine the functionality of "/health" endpoint
URL: https://github.com/apache/airflow/pull/4309#issuecomment-452715064
 
 
   Hi @ashb , @kaxil , @feng-tao , may you take another look at this PR?
   
   
   **Latest updates:**
   
   - A few nice & valid points raised by @feng-tao earlier are addressed.
   - @Mokubyow suggested to use scheduler heartbeat time in `job` table to decide health status of scheduler, rather than the latest scheduler run time in `dag` table. This is a nice suggestion, and is addressed in the latest commit of this PR.
   
   So now the response of `/health` endpoint will be
   
   ```
     {
       "metadatabase":{
         "status":"healthy"
       },
       "scheduler":{
         "status":"healthy",
         "latest_scheduler_heartbeat":"2018-12-26 17:15:11+00:00"
       }
     }
   ```
   
   (the only two valid values of `status` are "healthy"/"unhealthy")
   
   For other details, please refer to [my earlier comment](https://github.com/apache/airflow/pull/4309#issuecomment-449681029).
   
   Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services