[GitHub] [doris] dataroaring commented on a diff in pull request #18831: [Improvement] enhance show data types stmt

["dataroaring (via GitHub)" <gi...@apache.org>]

dataroaring commented on code in PR #18831:
URL: https://github.com/apache/doris/pull/18831#discussion_r1174516570


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ShowDataTypesStmt.java:
##########
@@ -41,6 +43,33 @@ public static ArrayList<PrimitiveType> getTypes() {
         return PrimitiveType.getSupportedTypes();
     }
 
+    public static List<List<String>> getFilterTypes() {
+        ArrayList<PrimitiveType> supportedTypes = getTypes();
+        List<List<String>> rows = Lists.newArrayList();
+        boolean hasDecimalv3 = false;
+        for (PrimitiveType type : supportedTypes) {
+            List<String> row = new ArrayList<>();
+            if (type.isAvailableInDdl()) {
+                if (type.isDecimalV2Type()) {
+                    row.add("DECIMAL");

Review Comment:
   We should not handle type name here, should be handled in PrimitiveType too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org