You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2020/02/01 01:17:29 UTC

[Impala-ASF-CR] IMPALA-9346: Fix TestImpalaShell.test config file failing issue on CentOS6/Python 2.6 

Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15139


Change subject: IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue on CentOS6/Python 2.6
......................................................................

IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue
on CentOS6/Python 2.6

Run the two negative test cases with warning message and error
message in separate impala-shell commands.

Testing:
 - Passed all test cases in test_shell_commandline.py and
   test_shell_interactive.py.
 - Passed all core test in pre-review-test.
 - Passed EE tests in impala-private-parameterized with CentOS6.

Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
---
M tests/shell/impalarc_with_error2
A tests/shell/impalarc_with_warnings2
M tests/shell/test_shell_commandline.py
3 files changed, 18 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/15139/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
Gerrit-Change-Number: 15139
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-9346: Fix TestImpalaShell.test config file failing issue on CentOS6/Python 2.6

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15139 )

Change subject: IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue on CentOS6/Python 2.6
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5488/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
Gerrit-Change-Number: 15139
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 01 Feb 2020 01:37:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9346: Fix TestImpalaShell.test config file failing issue on CentOS6/Python 2.6

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has removed a vote on this change.

Change subject: IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue on CentOS6/Python 2.6
......................................................................


Removed Code-Review+2 by Impala Public Jenkins <im...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/15139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
Gerrit-Change-Number: 15139
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9346: Fix TestImpalaShell.test config file failing issue on CentOS6/Python 2.6

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15139 )

Change subject: IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue on CentOS6/Python 2.6
......................................................................

IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue
on CentOS6/Python 2.6

ImpalaShell.test_config_file failed in negative test case, which
ran impala shell with bad format config file - wrong option name and
wrong option value. The testing code expect impala shell return both
warning and error messages. But on CentOS6/Python 2.6, Impala shell
only return error message. To fix it, separate the test cases as two
test cases by running Impala shell in two different config file.

Testing:
 - Passed all test cases in test_shell_commandline.py and
   test_shell_interactive.py.
 - Passed all core test in pre-review-test.
 - Passed EE tests in impala-private-parameterized with CentOS6.

Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
---
M tests/shell/impalarc_with_error2
A tests/shell/impalarc_with_warnings2
M tests/shell/test_shell_commandline.py
3 files changed, 18 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/15139/4
-- 
To view, visit http://gerrit.cloudera.org:8080/15139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
Gerrit-Change-Number: 15139
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9346: Fix TestImpalaShell.test config file failing issue on CentOS6/Python 2.6

Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/15139 )

Change subject: IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue on CentOS6/Python 2.6
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15139/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15139/3//COMMIT_MSG@10
PS3, Line 10: Run the two negative test cases with warning message and error
            : message in separate impala-shell commands.
can you mention the root cause of this issue. Like why you had to make this change?



-- 
To view, visit http://gerrit.cloudera.org:8080/15139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
Gerrit-Change-Number: 15139
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 01 Feb 2020 01:41:16 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9346: Fix TestImpalaShell.test config file failing issue on CentOS6/Python 2.6

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15139 )

Change subject: IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue on CentOS6/Python 2.6
......................................................................


Patch Set 2:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/5579/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/15139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
Gerrit-Change-Number: 15139
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 01 Feb 2020 02:03:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9346: Fix TestImpalaShell.test config file failing issue on CentOS6/Python 2.6

Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/15139 )

Change subject: IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue on CentOS6/Python 2.6
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15139/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15139/4//COMMIT_MSG@13
PS4, Line 13: CentOS6/Python 2.6
can you dig into whether this is a centos6 or a python2.6 issue and why the behavior is different? I think its important to specify the first part but I am fine with letting this patch in without figuring out the second part just to unblock the builds. But in any case I think we should later figure out why the behavior is different.



-- 
To view, visit http://gerrit.cloudera.org:8080/15139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
Gerrit-Change-Number: 15139
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 01 Feb 2020 02:14:53 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9346: Fix TestImpalaShell.test config file failing issue on CentOS6/Python 2.6

Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/15139 )

Change subject: IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue on CentOS6/Python 2.6
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
Gerrit-Change-Number: 15139
Gerrit-PatchSet: 5
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Feb 2020 20:00:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9346: Fix TestImpalaShell.test config file failing issue on CentOS6/Python 2.6

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15139 )

Change subject: IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue on CentOS6/Python 2.6
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
Gerrit-Change-Number: 15139
Gerrit-PatchSet: 6
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Feb 2020 20:00:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9346: Fix TestImpalaShell.test config file failing issue on CentOS6/Python 2.6

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15139 )

Change subject: IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue on CentOS6/Python 2.6
......................................................................


Patch Set 5: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
Gerrit-Change-Number: 15139
Gerrit-PatchSet: 5
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Feb 2020 18:14:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9346: Fix TestImpalaShell.test config file failing issue on CentOS6/Python 2.6

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15139 )

Change subject: IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue on CentOS6/Python 2.6
......................................................................


Patch Set 4:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/5580/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/15139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
Gerrit-Change-Number: 15139
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 01 Feb 2020 02:50:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9346: Fix TestImpalaShell.test config file failing issue on CentOS6/Python 2.6

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15139 )

Change subject: IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue on CentOS6/Python 2.6
......................................................................


Patch Set 3:

Bikram makes a good point.


-- 
To view, visit http://gerrit.cloudera.org:8080/15139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
Gerrit-Change-Number: 15139
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 01 Feb 2020 01:44:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9346: Fix TestImpalaShell.test config file failing issue on CentOS6/Python 2.6

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15139 )

Change subject: IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue on CentOS6/Python 2.6
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
Gerrit-Change-Number: 15139
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 01 Feb 2020 01:37:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9346: Fix TestImpalaShell.test config file failing issue on CentOS6/Python 2.6

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15139 )

Change subject: IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue on CentOS6/Python 2.6
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5581/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
Gerrit-Change-Number: 15139
Gerrit-PatchSet: 5
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sun, 02 Feb 2020 01:02:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9346: Fix TestImpalaShell.test config file failing issue on CentOS6/Python 2.6

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15139 )

Change subject: IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue on CentOS6/Python 2.6
......................................................................


Patch Set 6: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
Gerrit-Change-Number: 15139
Gerrit-PatchSet: 6
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Feb 2020 00:55:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9346: Fix TestImpalaShell.test config file failing issue on CentOS6/Python 2.6

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15139 )

Change subject: IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue on CentOS6/Python 2.6
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
Gerrit-Change-Number: 15139
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 01 Feb 2020 01:37:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9346: Fix TestImpalaShell.test config file failing issue on CentOS6/Python 2.6

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/15139 )

Change subject: IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue on CentOS6/Python 2.6
......................................................................

IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue
on CentOS6/Python 2.6

ImpalaShell.test_config_file failed in negative test case, which
ran impala shell with bad format config file - wrong option name and
wrong option value. The testing code expect impala shell return both
warning and error messages. But on CentOS6/Python 2.6, Impala shell
only return error message. To fix it, separate the test cases as two
test cases by running Impala shell in two different config file.

Testing:
 - Passed all test cases in test_shell_commandline.py and
   test_shell_interactive.py.
 - Passed all core test in pre-review-test.
 - Passed EE tests in impala-private-parameterized with CentOS6.

Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
---
M bin/rat_exclude_files.txt
M tests/shell/impalarc_with_error2
A tests/shell/impalarc_with_warnings2
M tests/shell/test_shell_commandline.py
4 files changed, 19 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/15139/5
-- 
To view, visit http://gerrit.cloudera.org:8080/15139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
Gerrit-Change-Number: 15139
Gerrit-PatchSet: 5
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-9346: Fix TestImpalaShell.test config file failing issue on CentOS6/Python 2.6

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15139 )

Change subject: IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue on CentOS6/Python 2.6
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5492/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
Gerrit-Change-Number: 15139
Gerrit-PatchSet: 6
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Feb 2020 20:00:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9346: Fix TestImpalaShell.test config file failing issue on CentOS6/Python 2.6

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15139 )

Change subject: IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue on CentOS6/Python 2.6
......................................................................

IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue
on CentOS6/Python 2.6

ImpalaShell.test_config_file failed in negative test case, which
ran impala shell with bad format config file - wrong option name and
wrong option value. The testing code expect impala shell return both
warning and error messages. But on CentOS6/Python 2.6, Impala shell
only return error message. To fix it, separate the test cases as two
test cases by running Impala shell in two different config file.

Testing:
 - Passed all test cases in test_shell_commandline.py and
   test_shell_interactive.py.
 - Passed all core test in pre-review-test.
 - Passed EE tests in impala-private-parameterized with CentOS6.

Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
Reviewed-on: http://gerrit.cloudera.org:8080/15139
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/rat_exclude_files.txt
M tests/shell/impalarc_with_error2
A tests/shell/impalarc_with_warnings2
M tests/shell/test_shell_commandline.py
4 files changed, 19 insertions(+), 4 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
Gerrit-Change-Number: 15139
Gerrit-PatchSet: 7
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-9346: Fix TestImpalaShell.test config file failing issue on CentOS6/Python 2.6

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/15139 )

Change subject: IMPALA-9346: Fix TestImpalaShell.test_config_file failing issue on CentOS6/Python 2.6
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15139/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15139/3//COMMIT_MSG@10
PS3, Line 10: ImpalaShell.test_config_file failed in negative test case, which
            : ran impala shell with bad format config fi
> can you mention the root cause of this issue. Like why you had to make this
Update it as below:

ImpalaShell.test_config_file failed in negative test case, which ran impala shell with bad format config file - wrong option name and wrong option value. The testing code expect impala shell return both warning and error messages. But on CentOS6/Python 2.6, Impala shell only return error message. To fix it, separate the test cases as two test cases by running Impala shell in two different config file.



-- 
To view, visit http://gerrit.cloudera.org:8080/15139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief5e825aa3baead5519132d47efcf0d5300860fd
Gerrit-Change-Number: 15139
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 01 Feb 2020 02:06:01 +0000
Gerrit-HasComments: Yes