[jira] [Work logged] (HADOOP-17409) Remove S3Guard - no longer needed

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-17409?focusedWorklogId=677035&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-677035 ]

ASF GitHub Bot logged work on HADOOP-17409:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Nov/21 13:13
            Start Date: 05/Nov/21 13:13
    Worklog Time Spent: 10m 
      Work Description: steveloughran commented on a change in pull request #3534:
URL: https://github.com/apache/hadoop/pull/3534#discussion_r743649221



##########
File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/InconsistentS3Object.java
##########
@@ -173,7 +173,7 @@ private void skipFailpoint(long len) throws IOException {
   }
 
   private boolean shouldInjectFailure(String key) {
-    if (policy.shouldDelay(key) &&
+    if (false &&
         readFailureCounter < MAX_READ_FAILURES) {
       readFailureCounter++;
       return true;

Review comment:
       i've reinstated the whole ability to go inconsistent, in case anyone really wants it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 677035)
    Time Spent: 1h  (was: 50m)

> Remove S3Guard - no longer needed
> ---------------------------------
>
>                 Key: HADOOP-17409
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17409
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs/s3
>    Affects Versions: 3.3.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> With Consistent S3, S3Guard is superfluous. 
> stop developing it and wean people off it as soon as they can.
> Then we can worry about what to do in the code. It has gradually insinuated its way through the layers, especially things like multi-object delete handling (see HADOOP-17244). Things would be a lot simpler without it
> This work is being done in the feature branch HADOOP-17409-remove-s3guard



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org