You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/01 05:45:06 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
HyukjinKwon opened a new pull request #31408:
URL: https://github.com/apache/spark/pull/31408
### What changes were proposed in this pull request?
This PR completes SPARK-10621 and makes functions APIs to use snake_case across the languages.
In more details, this PR:
- Adds `count_distinct` in Scala Python, and R, and document that `count_distinct` is encouraged. This was not deprecated because `countDistinct` is pretty commonly used. We could deprecate in the future releases.
- Deprecates and renames:
- `sumDistinct` -> `sum_distinct`
- `bitwiseNOT` -> `bitwise_not`
- `shiftLeft -> `shiftleft` (matched with SQL name in `FunctionRegistry`)
- `shiftRight -> `shiftright` (matched with SQL name in `FunctionRegistry`)
- `shiftRightUnsigned` -> `shiftrightunsigned` (matched with SQL name in `FunctionRegistry`)
- (Scala-specific) `typedLit` -> `typedlit`
- (Scala-specific) `callUDF` -> `call_udf`
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770701135
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39307/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31408:
URL: https://github.com/apache/spark/pull/31408#discussion_r567582370
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -123,9 +133,9 @@ object functions {
* can handle parameterized scala types e.g.: List, Seq and Map.
*
* @group normal_funcs
- * @since 2.2.0
+ * @since 3.2.0
*/
- def typedLit[T : TypeTag](literal: T): Column = literal match {
+ def typedlit[T : TypeTag](literal: T): Column = literal match {
Review comment:
not `typed_lit` but `typedlit`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770658436
**[Test build #134721 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134721/testReport)** for PR 31408 at commit [`6d8ef89`](https://github.com/apache/spark/commit/6d8ef89f4aaeac7103721f404e720d186b746f2b).
* This patch **fails R style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770654388
**[Test build #134721 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134721/testReport)** for PR 31408 at commit [`6d8ef89`](https://github.com/apache/spark/commit/6d8ef89f4aaeac7103721f404e720d186b746f2b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] rxin commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
rxin commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-771075815
This makes sense, assuming we don't break backward compatibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31408:
URL: https://github.com/apache/spark/pull/31408
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770725556
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770684873
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134721/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31408:
URL: https://github.com/apache/spark/pull/31408#discussion_r567583279
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -123,9 +133,9 @@ object functions {
* can handle parameterized scala types e.g.: List, Seq and Map.
*
* @group normal_funcs
- * @since 2.2.0
+ * @since 3.2.0
*/
- def typedLit[T : TypeTag](literal: T): Column = literal match {
+ def typedlit[T : TypeTag](literal: T): Column = literal match {
Review comment:
For some reasons I like `typedlit` (like `datediff`, `shiftleft, etc.). But I don't mind changing it back if other people prefer `typed_lit` more. It's not even in the function registry in any event so I think we can pick one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #31408:
URL: https://github.com/apache/spark/pull/31408#discussion_r568043656
##########
File path: R/pkg/R/functions.R
##########
@@ -636,20 +636,33 @@ setMethod("bin",
})
#' @details
-#' \code{bitwiseNOT}: Computes bitwise NOT.
+#' \code{bitwise_not}: Computes bitwise NOT.
#'
#' @rdname column_nonaggregate_functions
-#' @aliases bitwiseNOT bitwiseNOT,Column-method
+#' @aliases bitwise_not bitwise_not,Column-method
#' @examples
#'
#' \dontrun{
-#' head(select(df, bitwiseNOT(cast(df$vs, "int"))))}
+#' head(select(df, bitwise_not(cast(df$vs, "int"))))}
+#' @note bitwise_not since 3.2.0
+setMethod("bitwise_not",
+ signature(x = "Column"),
+ function(x) {
+ jc <- callJStatic("org.apache.spark.sql.functions", "bitwise_not", x@jc)
+ column(jc)
+ })
+
+#' @details
+#' \code{bitwiseNOT}: Computes bitwise NOT.
+#'
+#' @rdname column_nonaggregate_functions
+#' @aliases bitwiseNOT bitwiseNOT,Column-method
#' @note bitwiseNOT since 1.5.0
setMethod("bitwiseNOT",
signature(x = "Column"),
function(x) {
- jc <- callJStatic("org.apache.spark.sql.functions", "bitwiseNOT", x@jc)
- column(jc)
+ .Deprecated("bitwise_not")
Review comment:
Shall we not deprecate this because Apache Spark cannot delete this in the future?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770594177
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770763424
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31408:
URL: https://github.com/apache/spark/pull/31408#discussion_r567585448
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -113,6 +113,16 @@ object functions {
*/
def lit(literal: Any): Column = typedLit(literal)
+ /**
+ * Creates a [[Column]] of literal value.
+ *
+ * An alias of `typedlit`, and it is encouraged to use `typedlit` directly.
+ *
+ * @group normal_funcs
Review comment:
Oh, I see. Yea, I misunderstood it from the word "deprecate" there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770739581
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39309/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770760965
**[Test build #134710 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134710/testReport)** for PR 31408 at commit [`bb23512`](https://github.com/apache/spark/commit/bb235121bbfcfe4f6accac1a12d9ee9d02ac53ee).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770596916
**[Test build #134710 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134710/testReport)** for PR 31408 at commit [`bb23512`](https://github.com/apache/spark/commit/bb235121bbfcfe4f6accac1a12d9ee9d02ac53ee).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770594177
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39292/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770684873
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134721/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770596916
**[Test build #134710 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134710/testReport)** for PR 31408 at commit [`bb23512`](https://github.com/apache/spark/commit/bb235121bbfcfe4f6accac1a12d9ee9d02ac53ee).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31408:
URL: https://github.com/apache/spark/pull/31408#discussion_r567583279
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -123,9 +133,9 @@ object functions {
* can handle parameterized scala types e.g.: List, Seq and Map.
*
* @group normal_funcs
- * @since 2.2.0
+ * @since 3.2.0
*/
- def typedLit[T : TypeTag](literal: T): Column = literal match {
+ def typedlit[T : TypeTag](literal: T): Column = literal match {
Review comment:
For some reasons I like `typedlit` (like `datediff`, `shiftleft`, etc.). But I don't mind changing it back if other people prefer `typed_lit` more. It's not for SQL compliance and not in the function registry in any event so I think we can pick one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31408:
URL: https://github.com/apache/spark/pull/31408
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770687790
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39307/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-771257354
Thanks all. Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-771257354
Thanks all. Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770763423
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31408:
URL: https://github.com/apache/spark/pull/31408#discussion_r567584080
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -123,9 +133,9 @@ object functions {
* can handle parameterized scala types e.g.: List, Seq and Map.
*
* @group normal_funcs
- * @since 2.2.0
+ * @since 3.2.0
*/
- def typedLit[T : TypeTag](literal: T): Column = literal match {
+ def typedlit[T : TypeTag](literal: T): Column = literal match {
Review comment:
Ah, I see. I just wanted to know the reason. The current one looks fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #31408:
URL: https://github.com/apache/spark/pull/31408#discussion_r568056115
##########
File path: R/pkg/R/functions.R
##########
@@ -636,20 +636,33 @@ setMethod("bin",
})
#' @details
-#' \code{bitwiseNOT}: Computes bitwise NOT.
+#' \code{bitwise_not}: Computes bitwise NOT.
#'
#' @rdname column_nonaggregate_functions
-#' @aliases bitwiseNOT bitwiseNOT,Column-method
+#' @aliases bitwise_not bitwise_not,Column-method
#' @examples
#'
#' \dontrun{
-#' head(select(df, bitwiseNOT(cast(df$vs, "int"))))}
+#' head(select(df, bitwise_not(cast(df$vs, "int"))))}
+#' @note bitwise_not since 3.2.0
+setMethod("bitwise_not",
+ signature(x = "Column"),
+ function(x) {
+ jc <- callJStatic("org.apache.spark.sql.functions", "bitwise_not", x@jc)
+ column(jc)
+ })
+
+#' @details
+#' \code{bitwiseNOT}: Computes bitwise NOT.
+#'
+#' @rdname column_nonaggregate_functions
+#' @aliases bitwiseNOT bitwiseNOT,Column-method
#' @note bitwiseNOT since 1.5.0
setMethod("bitwiseNOT",
signature(x = "Column"),
function(x) {
- jc <- callJStatic("org.apache.spark.sql.functions", "bitwiseNOT", x@jc)
- column(jc)
+ .Deprecated("bitwise_not")
Review comment:
That's a reasonable position too. You _could_ in 4.0, but, dont' imagine anyone would consider it worth breaking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31408:
URL: https://github.com/apache/spark/pull/31408#discussion_r568197703
##########
File path: R/pkg/R/functions.R
##########
@@ -636,20 +636,33 @@ setMethod("bin",
})
#' @details
-#' \code{bitwiseNOT}: Computes bitwise NOT.
+#' \code{bitwise_not}: Computes bitwise NOT.
#'
#' @rdname column_nonaggregate_functions
-#' @aliases bitwiseNOT bitwiseNOT,Column-method
+#' @aliases bitwise_not bitwise_not,Column-method
#' @examples
#'
#' \dontrun{
-#' head(select(df, bitwiseNOT(cast(df$vs, "int"))))}
+#' head(select(df, bitwise_not(cast(df$vs, "int"))))}
+#' @note bitwise_not since 3.2.0
+setMethod("bitwise_not",
+ signature(x = "Column"),
+ function(x) {
+ jc <- callJStatic("org.apache.spark.sql.functions", "bitwise_not", x@jc)
+ column(jc)
+ })
+
+#' @details
+#' \code{bitwiseNOT}: Computes bitwise NOT.
+#'
+#' @rdname column_nonaggregate_functions
+#' @aliases bitwiseNOT bitwiseNOT,Column-method
#' @note bitwiseNOT since 1.5.0
setMethod("bitwiseNOT",
signature(x = "Column"),
function(x) {
- jc <- callJStatic("org.apache.spark.sql.functions", "bitwiseNOT", x@jc)
- column(jc)
+ .Deprecated("bitwise_not")
Review comment:
I think deprecation is fine because it guides users to use the encouraged way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770638685
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39296/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770649577
Yeah, these are everything if I didn't miss. I could take the Scala specific ones out but just thought it's better to keep it consistent within `functions.scala` too, and they are only two (`callUDF` and `typedLit`). I don't mind changing these two back if any of you feel it shouldn't be changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770647265
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39296/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770725556
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770647265
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39296/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770594532
**[Test build #134706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134706/testReport)** for PR 31408 at commit [`a1b682a`](https://github.com/apache/spark/commit/a1b682a3ce6f6156cf9c8b3484c833831217932c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31408:
URL: https://github.com/apache/spark/pull/31408#discussion_r567577270
##########
File path: python/docs/source/reference/pyspark.sql.rst
##########
@@ -482,9 +484,9 @@ Functions
sequence
sha1
sha2
- shiftLeft
- shiftRight
- shiftRightUnsigned
+ shiftleft
+ shiftright
+ shiftrightunsigned
Review comment:
I should rename it here - the case sensitivity is not taken into account in `sphinx.ext.autosummary` which I think it's due to the file name conflicts at RST stub files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770654388
**[Test build #134721 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134721/testReport)** for PR 31408 at commit [`6d8ef89`](https://github.com/apache/spark/commit/6d8ef89f4aaeac7103721f404e720d186b746f2b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31408:
URL: https://github.com/apache/spark/pull/31408#discussion_r567577270
##########
File path: python/docs/source/reference/pyspark.sql.rst
##########
@@ -482,9 +484,9 @@ Functions
sequence
sha1
sha2
- shiftLeft
- shiftRight
- shiftRightUnsigned
+ shiftleft
+ shiftright
+ shiftrightunsigned
Review comment:
I should rename it here - the case sensitivity is not taken into account `sphinx.ext.autosummary` due to the file name conflicts at RST stub files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770621624
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39296/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770615881
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134706/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31408:
URL: https://github.com/apache/spark/pull/31408#discussion_r567583763
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -113,6 +113,16 @@ object functions {
*/
def lit(literal: Any): Column = typedLit(literal)
+ /**
+ * Creates a [[Column]] of literal value.
+ *
+ * An alias of `typedlit`, and it is encouraged to use `typedlit` directly.
+ *
+ * @group normal_funcs
Review comment:
oh I didn't intend to deprecate this (and `count_dictinct`). I will fix PR description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770695341
**[Test build #134723 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134723/testReport)** for PR 31408 at commit [`414d833`](https://github.com/apache/spark/commit/414d833d06c33f2b0ec006327bbf96df69da7c83).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31408:
URL: https://github.com/apache/spark/pull/31408#discussion_r567583045
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -113,6 +113,16 @@ object functions {
*/
def lit(literal: Any): Column = typedLit(literal)
+ /**
+ * Creates a [[Column]] of literal value.
+ *
+ * An alias of `typedlit`, and it is encouraged to use `typedlit` directly.
+ *
+ * @group normal_funcs
Review comment:
Could we use `@deprecated` for these aliases?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770594532
**[Test build #134706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134706/testReport)** for PR 31408 at commit [`a1b682a`](https://github.com/apache/spark/commit/a1b682a3ce6f6156cf9c8b3484c833831217932c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770600258
**[Test build #134706 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134706/testReport)** for PR 31408 at commit [`a1b682a`](https://github.com/apache/spark/commit/a1b682a3ce6f6156cf9c8b3484c833831217932c).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770720007
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39309/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31408:
URL: https://github.com/apache/spark/pull/31408#discussion_r567577270
##########
File path: python/docs/source/reference/pyspark.sql.rst
##########
@@ -482,9 +484,9 @@ Functions
sequence
sha1
sha2
- shiftLeft
- shiftRight
- shiftRightUnsigned
+ shiftleft
+ shiftright
+ shiftrightunsigned
Review comment:
I should rename it here - the case sensitivity is not taken into account `sphinx.ext.autosummary` due to the file name conflicts at RST stubs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31408:
URL: https://github.com/apache/spark/pull/31408#issuecomment-770588842
cc @rxin, @srowen, @zero323, and @viirya FYI. Could you take a look please when you guys find some time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org