You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/04/21 02:03:40 UTC
[PR] chore: simplify frontend dependencies and remove unused packages [texera]
aglinxinyuan opened a new pull request, #4430:
URL: https://github.com/apache/texera/pull/4430
## Summary
This PR simplifies the `frontend/` dependency graph by removing unused direct dependencies, dropping stale tooling packages, and keeping only the runtime and type packages that are actually required by the current Angular workspace.
## What changes were proposed in this PR?
- Removed unused direct runtime dependencies:
- `@loaders.gl/core`
- `@luma.gl/core`
- `@stoplight/json-ref-resolver`
- `backbone`
- `edit-distance`
- `es6-weak-map`
- `ng2-pdf-viewer`
- `ngx-image-viewer`
- `popper.js`
- `ts-proto`
- `vscode-ws-jsonrpc`
- Removed stale tooling dependencies:
- `@nrwl/cli`
- `@nrwl/nx-cloud`
- `nz-tslint-rules`
- `babel-plugin-dynamic-import-node`
- `ts-node`
- Kept `monaco-languageclient`, Angular devkit/schematics packages, and other peer-driven dependencies that are still required by the current workspace/tooling setup
- Kept `@types/lodash-es` and `@types/plotly.js-basic-dist-min` after verifying they are required for TypeScript compilation
- Added `@bufbuild/protobuf` explicitly as a direct dependency because checked-in generated protobuf TypeScript files import `@bufbuild/protobuf/wire` at build time
- Regenerated `frontend/yarn.lock`
Several packages in `frontend/package.json` were no longer referenced by application code, Angular config, Karma config, custom webpack config, or local scripts. Some were only being retained accidentally through transitive installs.
This cleanup makes the dependency graph more intentional by:
- removing dead direct dependencies
- removing obsolete tooling leftovers
- making real compile/runtime dependencies explicit
### Any related issues, documentation, discussions?
Closes #4429
### How was this PR tested?
- `yarn.cmd install`
- `yarn.cmd build`
- `yarn.cmd test --watch=false`
Build and tests both pass.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Codex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): simplify frontend dependencies and remove unused packages [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #4430:
URL: https://github.com/apache/texera/pull/4430#discussion_r3114642114
##########
frontend/package.json:
##########
@@ -69,28 +62,23 @@
"monaco-editor-wrapper": "5.5.3",
"monaco-languageclient": "8.8.3",
"ng-zorro-antd": "17.4.1",
- "ng2-pdf-viewer": "9.1.5",
"ngx-color-picker": "12.0.1",
"ngx-file-drop": "16.0.0",
- "ngx-image-viewer": "1.0.13",
"ngx-json-viewer": "3.2.1",
"ngx-markdown": "17.2.1",
"papaparse": "5.4.1",
"path-browserify": "1.0.1",
"plotly.js-basic-dist-min": "2.29.0",
- "popper.js": "1.16.1",
"quill": "1.3.7",
"quill-cursors": "3.1.2",
"read-excel-file": "5.7.1",
"ring-buffer-ts": "1.0.3",
"rxjs": "7.8.1",
"tinyqueue": "2.0.3",
Review Comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): simplify frontend dependencies and remove unused packages [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on PR #4430:
URL: https://github.com/apache/texera/pull/4430#issuecomment-4285892968
> LGTM!
> tested with: yarn install, yarn build, yarn test.
>
> One comment: Not a new issue introduced by this PR, but while we are cleaning up dependencies: the generated frontend proto files directly import @bufbuild/protobuf/wire. Today this package is only pulled transitively through ts-proto. Should we declare @bufbuild/protobuf explicitly in dependencies to match the direct import?
>
After thinking it through, we should avoid importing child dependencies more than once, especially when they’re already included as dependencies of other children. We should keep it minimal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): simplify frontend dependencies and remove unused packages [texera]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #4430:
URL: https://github.com/apache/texera/pull/4430#discussion_r3114629700
##########
frontend/package.json:
##########
@@ -69,28 +62,23 @@
"monaco-editor-wrapper": "5.5.3",
"monaco-languageclient": "8.8.3",
"ng-zorro-antd": "17.4.1",
- "ng2-pdf-viewer": "9.1.5",
"ngx-color-picker": "12.0.1",
"ngx-file-drop": "16.0.0",
- "ngx-image-viewer": "1.0.13",
"ngx-json-viewer": "3.2.1",
"ngx-markdown": "17.2.1",
"papaparse": "5.4.1",
"path-browserify": "1.0.1",
"plotly.js-basic-dist-min": "2.29.0",
- "popper.js": "1.16.1",
"quill": "1.3.7",
"quill-cursors": "3.1.2",
"read-excel-file": "5.7.1",
"ring-buffer-ts": "1.0.3",
"rxjs": "7.8.1",
"tinyqueue": "2.0.3",
Review Comment:
`bin/frontend-proto-gen.sh` invokes `frontend/node_modules/.bin/protoc-gen-ts_proto`, which is typically provided by the `ts-proto` npm package. Since this PR removes `ts-proto` from `dependencies`, the proto generation script will fail unless the plugin is provided some other way. Consider keeping `ts-proto` as a `devDependency` (or updating/removing the script if it's intentionally deprecated).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(deps): simplify frontend dependencies and remove unused packages [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #4430:
URL: https://github.com/apache/texera/pull/4430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org