You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "jason810496 (via GitHub)" <gi...@apache.org> on 2026/10/12 11:21:44 UTC

Re: [PR] Skip log accumulator disk spill when reading finished task logs [airflow]

jason810496 commented on code in PR #70671:
URL: https://github.com/apache/airflow/pull/70671#discussion_r4247431627


##########
ui-continue-token-plan.md:
##########
@@ -0,0 +1,124 @@
+<!--

Review Comment:
   Good catch, dropped in 07c855d89a1.



##########
airflow-core/src/airflow/utils/log/file_task_handler.py:
##########
@@ -683,6 +683,18 @@ def _read(
             TaskInstanceState.DEFERRED,
         )
 
+        if end_of_log:

Review Comment:
   Agreed, updated in 3532cec7722: the skip/header logic now runs once, and only unfinished reads go through the accumulator.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org